Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement :-moz-anonymous-content in stylo #16877

Merged
merged 2 commits into from May 15, 2017
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Next

Fix style sharing cache lookups to compare ids of the two elements.

Otherwise we can have a situation like this:

  <style>
    .notmatching > #foo {}
  </style>
  <span id="foo"></span>
  <span></span>

and the style sharing cache lookup for the second <span> would try to revalidate
against the cached value for the first <span>, but end up failing asserts about
the two elements matching lists of revalidation selectors that have the same
length.
  • Loading branch information
bzbarsky committed May 15, 2017
commit 5ddf455235be2a31d10ef388572a35d2433361ae
@@ -176,7 +176,7 @@ fn element_matches_candidate<E: TElement>(element: &E,
miss!(State)
}

if element.get_id().is_some() {
if element.get_id() != candidate_element.get_id() {
miss!(IdAttr)
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.