Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upprovide more information when bindgen fails #16880
Merged
Conversation
|
r=me, with that nit |
components/style/build_gecko.rs
Outdated
| Ok(bindings) => bindings.to_string(), | ||
| Err(_) => { | ||
| println!("Failed to generate bindings, flags: {:?}", command_line_opts); | ||
| panic!("Unable to generate bindings"); |
This comment has been minimized.
This comment has been minimized.
emilio
May 15, 2017
Member
You can just panic!("Failed to generate bindings, flags: {:?}", command_line_opts).
Providing the flags we passed into clang can be informative for double-checking that we set everything up correctly.
froydnj
force-pushed the
froydnj:bindgen-informative-failure
branch
from
89d02c5
to
22db4b4
|
Thanks, fixed. |
|
@bors-servo r+ Thanks! |
|
|
|
|
|
bors-servo
added a commit
that referenced
this pull request
May 16, 2017
provide more information when bindgen fails Providing the flags we passed into clang can be informative for double-checking that we set everything up correctly. - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16880) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
froydnj commentedMay 15, 2017
•
edited by larsbergstrom
Providing the flags we passed into clang can be informative for double-checking that we set everything up correctly.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is