Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Continue to propagate quirks mode information to Servo #16882

Merged
merged 1 commit into from May 17, 2017

Conversation

@canova
Copy link
Member

canova commented May 15, 2017

r=bholley in bugzilla


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix Bug 1364746

This change is Reviewable

@highfive
Copy link

highfive commented May 15, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs
  • @emilio: components/style/gecko/generated/bindings.rs, ports/geckolib/glue.rs
@highfive
Copy link

highfive commented May 15, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@canova
Copy link
Member Author

canova commented May 15, 2017

@bors-servo r=bholley

@bors-servo
Copy link
Contributor

bors-servo commented May 15, 2017

📌 Commit 3acb3ca has been approved by bholley

@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2017

Testing commit 3acb3ca with merge 52cd67d...

bors-servo added a commit that referenced this pull request May 17, 2017
stylo: Continue to propagate quirks mode information to Servo

r=bholley in bugzilla

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1364746](https://bugzilla.mozilla.org/show_bug.cgi?id=1364746)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16882)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2017

💔 Test failed - mac-dev-unit

@emilio
Copy link
Member

emilio commented May 17, 2017

@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2017

Testing commit 3acb3ca with merge abb2985...

bors-servo added a commit that referenced this pull request May 17, 2017
stylo: Continue to propagate quirks mode information to Servo

r=bholley in bugzilla

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1364746](https://bugzilla.mozilla.org/show_bug.cgi?id=1364746)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16882)
<!-- Reviewable:end -->
@nox
Copy link
Member

nox commented May 17, 2017

@bors-servo
Copy link
Contributor

bors-servo commented May 17, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: bholley
Pushing abb2985 to master...

@bors-servo bors-servo merged commit 3acb3ca into servo:master May 17, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@canova canova deleted the canova:more-quirk branch May 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can’t perform that action at this time.