Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (Intel driver workaround, subpixel and other bugfixes). #16917

Merged
merged 1 commit into from May 22, 2017
Merged

Update WR (Intel driver workaround, subpixel and other bugfixes). #16917

merged 1 commit into from May 22, 2017

Conversation

@glennw
Copy link
Member

glennw commented May 17, 2017 •
edited by larsbergstrom

This change is Reviewable
@glennw
Copy link
Member Author

glennw commented May 17, 2017

I have a sneaking suspicion that the rayon changes in this PR are going to cause a heap of timeouts. But let's try anyway...
@glennw
Copy link
Member Author

glennw commented May 17, 2017

r? anyone
@glennw glennw force-pushed the glennw:update-wr-bugs branch from fbb0b53 to 0b39eb2 May 18, 2017
@wafflespeanut
Copy link
Member

wafflespeanut commented May 18, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2017

📌 Commit 0b39eb2 has been approved by Wafflespeanut
@glennw glennw force-pushed the glennw:update-wr-bugs branch from 0b39eb2 to 48a22e9 May 18, 2017
@glennw
Copy link
Member Author

glennw commented May 18, 2017

Rebased and updated to tip of WR with fix for #16777.
@glennw
Copy link
Member Author

glennw commented May 18, 2017

@bors-servo r=WafflesPeanut
@bors-servo
Copy link
Contributor

bors-servo commented May 18, 2017

📌 Commit 48a22e9 has been approved by WafflesPeanut
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2017

⌛ Testing commit 48a22e9 with merge 44257f2...
bors-servo added a commit that referenced this pull request May 19, 2017
@bors-servo
Auto merge of #16917 - glennw:update-wr-bugs, r=WafflesPeanut
Loading status checks…
44257f2 
Update WR (Intel driver workaround, subpixel and other bugfixes).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16917)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2017

💔 Test failed - linux-rel-wpt
@jdm
Copy link
Member

jdm commented May 19, 2017 

  ▶ TIMEOUT [expected PASS] /_mozilla/css/border_radius_elliptical_a.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ TIMEOUT [expected PASS] /_mozilla/css/border_radius_shorthand_a.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ TIMEOUT [expected PASS] /_mozilla/css/box_shadow_blur_fixed.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  └ 3.3 (Core Profile) Mesa 12.0.1

  ▶ TIMEOUT [expected PASS] /_mozilla/css/filter_opacity_a.html
  │ 
  │ VMware, Inc.
  │ Gallium 0.4 on softpipe
  │ 3.3 (Core Profile) Mesa 12.0.1
  └ Shutting down the Constellation after generating an output file or exit flag specified
@glennw glennw force-pushed the glennw:update-wr-bugs branch from 48a22e9 to e139eb6 May 21, 2017
@glennw
Copy link
Member Author

glennw commented May 21, 2017

@bors-servo r=Wafflespeanut

  • Rebased and updated to tip of WR. I suspect this is still going to timeout, but let's just test and see.
@bors-servo
Copy link
Contributor

bors-servo commented May 21, 2017

📌 Commit e139eb6 has been approved by Wafflespeanut
bors-servo added a commit that referenced this pull request May 22, 2017
@bors-servo
Auto merge of #16917 - glennw:update-wr-bugs, r=<try>
Loading status checks…
ec96f7b 
Update WR (Intel driver workaround, subpixel and other bugfixes).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16917)
<!-- Reviewable:end -->
@jdm
Copy link
Member

jdm commented May 22, 2017

@glennw That's #16982.
@glennw
Copy link
Member Author

glennw commented May 22, 2017

@jdm Does that mean we should just retry this with an r+ ?
@jdm
Copy link
Member

jdm commented May 22, 2017

Yep!
@jdm
Copy link
Member

jdm commented May 22, 2017

@bors-servo: try- retry
#16982
@jdm
Copy link
Member

jdm commented May 22, 2017

@bors-servo: r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

📌 Commit 2b49196 has been approved by emilio
@jdm
Copy link
Member

jdm commented May 22, 2017

Travis says:

92.19s$ ./mach build -d --verbose

cargo build -v

    Updating git repository `https://github.com/servo/webrender`

error: failed to load source for a dependency on `webrender_traits`

Caused by:

  Unable to update https://github.com/servo/webrender#c003d553

Caused by:

  failed to fetch into /home/travis/build/servo/servo/.cargo/git/db/webrender-c3596abe1cf4f320

Caused by:

  [9/-3] Object not found - no match for id (6902f7d200ad115e5e9a95e08303db15f0f0dbba)

Build FAILED in 0:00:00

The command "./mach build -d --verbose" exited with 101.
@jdm
Copy link
Member

jdm commented May 22, 2017

Actually, that looks like #16787 so ignore it.
@jdm jdm mentioned this pull request May 22, 2017
Closed
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

⌛ Testing commit 2b49196 with merge 5357968...
bors-servo added a commit that referenced this pull request May 22, 2017
@bors-servo
Auto merge of #16917 - glennw:update-wr-bugs, r=emilio
Loading status checks…
5357968 
Update WR (Intel driver workaround, subpixel and other bugfixes).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16917)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

💔 Test failed - linux-rel-wpt
@glennw
Copy link
Member Author

glennw commented May 22, 2017

@jdm Hmmm. I have not confirmed this, but my guess is that switching the rayon thread count to a maximum of 2 per process is triggering our data race bugs in different ways, that's making our known intermittents appear on different tests :(

I can possibly revert the WR change that I think is causing this (we used to hard code the rayon worker thread count to 4), but that seems like a very fragile fix / hack.

Alternatively, we could consider updating intermittent expectations for a lot of tests, which doesn't seem ideal either.

Any thoughts?

Either way - I'm going to run the tests again locally and see if they repro here, just to rule out anything else in WR causing this. But there's really just a small number of WR bug fixes in this update, nothing that I would expect to cause these issues...
@hiikezoe
Copy link
Contributor

hiikezoe commented May 22, 2017

A very similar failure happened on my other PR.
#16959 (comment)

So I think the fail is not this PR fault at all.
@emilio
Copy link
Member

emilio commented May 22, 2017

@glennw note that only one known non-flacky test failed here (see the filtered-wpt-errorsummary.log artifact).

And that one is #16982.

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

⌛ Testing commit 2b49196 with merge e91ffaf...
bors-servo added a commit that referenced this pull request May 22, 2017
@bors-servo
Auto merge of #16917 - glennw:update-wr-bugs, r=emilio
Loading status checks…
e91ffaf 
Update WR (Intel driver workaround, subpixel and other bugfixes).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16917)
<!-- Reviewable:end -->
@nox
Copy link
Member

nox commented May 22, 2017

Travis seems unhappy, I hope that wasn't an actual issue.
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing e91ffaf to master...
@bors-servo bors-servo merged commit 2b49196 into servo:master May 22, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@CAfromCA CAfromCA mentioned this pull request May 22, 2017
Closed
@glennw glennw deleted the glennw:update-wr-bugs branch May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants
@glennw @wafflespeanut @bors-servo @jdm @hiikezoe @emilio @nox @highfive @gw3583
You can’t perform that action at this time.