Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse -moz-alt-content as a whole content value (fixes #15726) #16947

Merged
merged 1 commit into from May 22, 2017
Merged

Parse -moz-alt-content as a whole content value (fixes #15726) #16947

merged 1 commit into from May 22, 2017

Conversation

@nox
Copy link
Member

nox commented May 19, 2017 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented May 19, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/counters.mako.rs, components/style/properties/gecko.mako.rs
  • @emilio: components/style/properties/longhand/counters.mako.rs, components/style/properties/gecko.mako.rs, components/layout/wrapper.rs
@highfive
Copy link

highfive commented May 19, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style and layout code, but no tests are modified. Please consider adding a test!
@nox
Copy link
Member Author

nox commented May 19, 2017

https://treeherder.mozilla.org/#/jobs?repo=try&revision=06eff3bfa78e72d64de4470a4edc4cf39c816235
@wafflespeanut
Copy link
Member

wafflespeanut commented May 19, 2017

Nice! @bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 19, 2017

📌 Commit f683561 has been approved by Wafflespeanut
@highfive highfive assigned wafflespeanut and unassigned mbrubeck May 19, 2017
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2017

⌛ Testing commit f683561 with merge 7e6e4ae...
bors-servo added a commit that referenced this pull request May 20, 2017
@bors-servo
Auto merge of #16947 - nox:moz-alt-content, r=Wafflespeanut
Loading status checks…
7e6e4ae 
Parse -moz-alt-content as a whole content value (fixes #15726)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16947)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request May 20, 2017
Merged
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2017

💔 Test failed - linux-rel-wpt
@wafflespeanut
Copy link
Member

wafflespeanut commented May 21, 2017

Bitrotted by #16967
@nox nox force-pushed the nox:moz-alt-content branch from f683561 to 6bdbced May 22, 2017
@nox
Copy link
Member Author

nox commented May 22, 2017

@bors-servo r=Wafflespeanut
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

📌 Commit 6bdbced has been approved by Wafflespeanut
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

⌛ Testing commit 6bdbced with merge 821359a...
bors-servo added a commit that referenced this pull request May 22, 2017
@bors-servo
Auto merge of #16947 - nox:moz-alt-content, r=Wafflespeanut
Loading status checks…
821359a 
Parse -moz-alt-content as a whole content value (fixes #15726)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16947)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

💔 Test failed - mac-dev-unit
@nox
Copy link
Member Author

nox commented May 22, 2017

@bors-servo retry

hdiutil: create failed - error -5341
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, windows-msvc-dev are reusable. Rebuilding only mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2...
@nox
Parse -moz-alt-content as a whole content value (fixes #15726)
Loading status checks…
499e814
@nox nox force-pushed the nox:moz-alt-content branch from 6bdbced to 499e814 May 22, 2017
@nox
Copy link
Member Author

nox commented May 22, 2017

@bors-servo r=Wafflespeanut
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

📌 Commit 499e814 has been approved by Wafflespeanut
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

⌛ Testing commit 499e814 with merge ba23a3b...
bors-servo added a commit that referenced this pull request May 22, 2017
@bors-servo
Auto merge of #16947 - nox:moz-alt-content, r=Wafflespeanut
Loading status checks…
ba23a3b 
Parse -moz-alt-content as a whole content value (fixes #15726)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16947)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

💔 Test failed - mac-rel-wpt2
@nox
Copy link
Member Author

nox commented May 22, 2017

@bors-servo retry #16982
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

⌛ Testing commit 499e814 with merge a03d0b8...
bors-servo added a commit that referenced this pull request May 22, 2017
@bors-servo
Auto merge of #16947 - nox:moz-alt-content, r=Wafflespeanut
Loading status checks…
a03d0b8 
Parse -moz-alt-content as a whole content value (fixes #15726)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16947)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: Wafflespeanut
Pushing a03d0b8 to master...
@bors-servo bors-servo merged commit 499e814 into servo:master May 22, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wafflespeanut wafflespeanut

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @wafflespeanut @bors-servo @mbrubeck
You can’t perform that action at this time.