Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive HasViewportPercentage 🍷 #16960

Merged
merged 2 commits into from May 20, 2017
Merged

Derive HasViewportPercentage 🍷 #16960

merged 2 commits into from May 20, 2017

Conversation

@nox
Copy link
Member

nox commented May 19, 2017 •
edited by larsbergstrom

This change is Reviewable
@highfive
Copy link

highfive commented May 19, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/background.mako.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/position.mako.rs, components/style/values/generics/position.rs, components/style/values/specified/length.rs and 15 more
  • @emilio: components/style/properties/longhand/background.mako.rs, components/style/values/computed/mod.rs, components/style/properties/longhand/position.mako.rs, components/style/values/generics/position.rs, components/style/values/specified/length.rs and 15 more
@highfive
Copy link

highfive commented May 19, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented May 20, 2017

This is so lovely!

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2017

📌 Commit 87ab2d6 has been approved by emilio
@highfive highfive assigned emilio and unassigned pcwalton May 20, 2017
@nox
Copy link
Member Author

nox commented May 20, 2017

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2017

⌛ Testing commit 87ab2d6 with merge b50c111fd912029bd10fb0814c096f20b6cbee63...
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2017

💔 Test failed - linux-dev
@nox
Copy link
Member Author

nox commented May 20, 2017

@bors-servo retry #16783
@nox nox added S-awaiting-merge and removed S-tests-failed labels May 20, 2017
nox added 2 commits May 19, 2017
@nox
Derive HasViewportPercentage 🍷
90bae7f
@nox
Remove a lot of unused imports
Loading status checks…
00bfc6b
@nox nox force-pushed the derive-all-the-things branch from 87ab2d6 to 00bfc6b May 20, 2017
@emilio
Copy link
Member

emilio commented May 20, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2017

📌 Commit 00bfc6b has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2017

⌛ Testing commit 00bfc6b with merge 4f0b24a...
bors-servo added a commit that referenced this pull request May 20, 2017
@bors-servo
Auto merge of #16960 - servo:derive-all-the-things, r=emilio
Loading status checks…
4f0b24a 
Derive HasViewportPercentage 🍷

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16960)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 20, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing 4f0b24a to master...
@bors-servo bors-servo mentioned this pull request May 20, 2017
Merged
4 of 4 tasks complete
@bors-servo bors-servo merged commit 00bfc6b into master May 20, 2017
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the derive-all-the-things branch May 20, 2017
@bors-servo bors-servo mentioned this pull request May 20, 2017
Merged
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@nox @highfive @emilio @bors-servo @pcwalton
You can’t perform that action at this time.