Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back out webkit-appearance support in stylo for now. #16996

Merged
merged 1 commit into from May 22, 2017
Merged

Back out webkit-appearance support in stylo for now. #16996

merged 1 commit into from May 22, 2017

Conversation

@bzbarsky
Copy link
Contributor

bzbarsky commented May 22, 2017 •
edited by larsbergstrom

See https://bugzilla.mozilla.org/show_bug.cgi?id=1365614 for web compat issues this causes.

  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented May 22, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/box.mako.rs
  • @emilio: components/style/properties/longhand/box.mako.rs
@highfive
Copy link

highfive commented May 22, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bzbarsky
Copy link
Contributor Author

bzbarsky commented May 22, 2017

@bors-servo r=bzbarsky p=10
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

📌 Commit 2e24c20 has been approved by bzbarsky
@MatsPalmgren @bzbarsky
Back out webkit-appearance support in stylo for now.
Loading status checks…
e8ba413 
See https://bugzilla.mozilla.org/show_bug.cgi?id=1365614 for web compat issues this causes.
@bzbarsky bzbarsky force-pushed the bzbarsky:backout-webkit-appearance branch from 2e24c20 to e8ba413 May 22, 2017
@bzbarsky bzbarsky changed the title Back our webkit-appearance support in stylo for now. Back out webkit-appearance support in stylo for now. May 22, 2017
@bzbarsky
Copy link
Contributor Author

bzbarsky commented May 22, 2017

@bors-servo r=bzbarsky p=10
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

📌 Commit e8ba413 has been approved by bzbarsky
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

⌛ Testing commit e8ba413 with merge e9c5860...
bors-servo added a commit that referenced this pull request May 22, 2017
@bors-servo
Auto merge of #16996 - bzbarsky:backout-webkit-appearance, r=bzbarsky
Loading status checks…
e9c5860 
Back out webkit-appearance support in stylo for now.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1365614 for web compat issues this causes.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1365614

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16996)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

💔 Test failed - linux-dev
@bzbarsky
Copy link
Contributor Author

bzbarsky commented May 22, 2017

@bors-servo retry
@mbrubeck
Copy link
Contributor

mbrubeck commented May 22, 2017

The test failure above was #16783.
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

⚡ Previous build results for android, arm32, arm64, linux-rel-css, mac-dev-unit, mac-rel-wpt1, windows-msvc-dev are reusable. Rebuilding only linux-dev, linux-rel-wpt, mac-rel-css, mac-rel-wpt2...
@bors-servo
Copy link
Contributor

bors-servo commented May 22, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: bzbarsky
Pushing e9c5860 to master...
@bors-servo bors-servo merged commit e8ba413 into servo:master May 22, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bzbarsky bzbarsky deleted the bzbarsky:backout-webkit-appearance branch May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
S-tests-failed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@bzbarsky @highfive @bors-servo @mbrubeck @jdm @MatsPalmgren
You can’t perform that action at this time.