Webdriver browsing contexts not pipelines

[asajeffrey]

At the moment, a webdriver session stores a pipeline_ids, which causes a mismatch with the spec, which asks a session to store a browsing context and a top-level browsing context. This PR fixes this mismatch.

---

• ./mach build -d does not report any errors
• ./mach test-tidy does not report any errors
• These changes do not require tests because we are not testing webdriver

---

This change is 

[highfive]

Heads up! This PR modifies the following files:

• @jgraham: components/webdriver_server/lib.rs
• @fitzgen: components/script/dom/htmliframeelement.rs, components/script/dom/document.rs, components/script/webdriver_handlers.rs, components/script/dom/history.rs, components/script/dom/windowproxy.rs and 10 more
• @KiChjang: components/script/dom/htmliframeelement.rs, components/script/dom/document.rs, components/script/webdriver_handlers.rs, components/script/dom/history.rs, components/script/dom/windowproxy.rs and 10 more

[highfive]

Warning

• These commits modify script code, but no tests are modified. Please consider adding a test!

[asajeffrey]

The first commit is from #16916.

[asajeffrey]

r? @jgraham

[asajeffrey]

This is part of the ongoing effort to introduce top-level browsing context ids, in order to support multiple windows (#13994). cc @jdm @cbrewster @paulrouget

[asajeffrey]

IRC conversation with @jgraham: http://logs.glob.uno/?c=mozilla%23servo&s=22+May+2017&e=22+May+2017#c678807 and http://logs.glob.uno/?c=mozilla%23servo&s=22+May+2017&e=22+May+2017#c678945.

TL;DR: argh testing! (I ended up driving servo by hand with curl, got it to navigate, traverse and execute a script.)

[asajeffrey]

#16916 has landed, so this PR is next in the queue.

[asajeffrey]

@jgraham are you OK reviewing this or should I find another victim?

[jgraham]

I'm not an expert on all of this code, but the changes seem quite reasonable.

---

Reviewed 12 of 12 files at r1.
Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

components/constellation/constellation.rs, line 906 at r1 (raw file):

            }
            // Handle a forward or back request
            // Handle a forward or back request

This seems to be duplicated.

---

components/script/dom/htmliframeelement.rs, line 501 at r1 (raw file):

        MozBrowserEvent::LocationChange(url, can_go_back, can_go_forward) => {
            BrowserElementLocationChangeEventDetail {
                url: Some(DOMString::from(url.as_str())),

Seems maybe unrelated?

---

components/webdriver_server/lib.rs, line 785 at r1 (raw file):

            Err(WebDriverError::new(ErrorStatus::UnsupportedOperation, "Failed to convert keycodes"))));

        // TODO: there's a race condition caused by these being two separate messages,

It's not quite clear what "these" means in this comment.

---

Comments from Reviewable

[asajeffrey]

Thanks! I made changes based on your comments.

---

Review status: all files reviewed at latest revision, 3 unresolved discussions.

---

components/constellation/constellation.rs, line 906 at r1 (raw file):

Previously, jgraham wrote…

This seems to be duplicated.

Oops. Fixed.

---

components/script/dom/htmliframeelement.rs, line 501 at r1 (raw file):

Previously, jgraham wrote…

Seems maybe unrelated?

OK, I reverted this change.

---

components/webdriver_server/lib.rs, line 785 at r1 (raw file):

Previously, jgraham wrote…

It's not quite clear what "these" means in this comment.

Fixed.

---

Comments from Reviewable

[jgraham]

Reviewed 4 of 4 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from Reviewable

[jgraham]

@bors-servo r+

[bors-servo]

📌 Commit 3f761be has been approved by jgraham

[bors-servo]

⌛ Testing commit 3f761be with merge 0bc7e2f...

[bors-servo]

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jgraham
Pushing 0bc7e2f to master...