Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out some mac builds #17003

Merged
merged 1 commit into from May 28, 2017

Conversation

Projects
None yet
5 participants
@larsbergstrom
Copy link
Contributor

commented May 23, 2017

Splits out the WPT and CSS tests on mac to twice as many builders, each.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 23, 2017

Heads up! This PR modifies the following files:

@larsbergstrom

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2017

This should not be landed until servo/saltfs#674 is complete.

@larsbergstrom

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2017

r? @jdm or @metajack

I think this is actually set to go, now that @edunham set up a TON of additional macs! Yay!

@highfive highfive assigned jdm and unassigned wafflespeanut May 25, 2017

@wafflespeanut

This comment has been minimized.

Copy link
Member

commented May 26, 2017

... and homu queue is empty 😄

- ./mach filter-intermittents css-errorsummary.log --log-intermittents intermittents.log --log-filteredsummary filtered-css-errorsummary.log --use-tracker
- bash ./etc/ci/lockfile_changed.sh
- bash ./etc/ci/manifest_changed.sh

mac-rel-css2:
- ./mach build --release

This comment has been minimized.

Copy link
@jdm

jdm May 26, 2017

Member

clean-nightlies?

@larsbergstrom larsbergstrom force-pushed the larsbergstrom:more_mac_builders branch from 507dfb4 to bf5728c May 26, 2017

@larsbergstrom

This comment has been minimized.

Copy link
Contributor Author

commented May 26, 2017

r? @jdm

I think it's fixed :-)

@jdm

This comment has been minimized.

Copy link
Member

commented May 27, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

📌 Commit bf5728c has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

⌛️ Testing commit bf5728c with merge fab7716...

bors-servo added a commit that referenced this pull request May 27, 2017

Auto merge of #17003 - larsbergstrom:more_mac_builders, r=jdm
Split out some mac builds

Splits out the WPT and CSS tests on mac to twice as many builders, each.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17003)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

💔 Test failed - mac-rel-css

@larsbergstrom

This comment has been minimized.

Copy link
Contributor Author

commented May 27, 2017

oh, gah, I forgot that I will need to make changes to:
https://github.com/servo/saltfs/blob/master/buildbot/master/files/config/master.cfg

And get them landed & deployed first.

@aneeshusa @edunham I need to stage that carefully, right? i.e., need to roll it out on buildbot and then immediately land this? I am kinda forgetting the exact details on adding/changing builder names.

@larsbergstrom

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 28, 2017

⌛️ Testing commit bf5728c with merge 9ae10c5...

bors-servo added a commit that referenced this pull request May 28, 2017

Auto merge of #17003 - larsbergstrom:more_mac_builders, r=jdm
Split out some mac builds

Splits out the WPT and CSS tests on mac to twice as many builders, each.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17003)
<!-- Reviewable:end -->
@larsbergstrom

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 28, 2017

⌛️ Testing commit bf5728c with merge 4ec2e8b...

bors-servo added a commit that referenced this pull request May 28, 2017

Auto merge of #17003 - larsbergstrom:more_mac_builders, r=jdm
Split out some mac builds

Splits out the WPT and CSS tests on mac to twice as many builders, each.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17003)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 28, 2017

@bors-servo bors-servo merged commit bf5728c into servo:master May 28, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

bors-servo added a commit to servo/saltfs that referenced this pull request May 28, 2017

Auto merge of #681 - larsbergstrom:add_mac_builders, r=Manishearth
Add mac builders

This adds more mac builders, in support of servo/servo#17003

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/saltfs/681)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.