Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylo: Deep clone ServoStyleSheets. #17028

Merged
merged 1 commit into from May 25, 2017
Merged

Stylo: Deep clone ServoStyleSheets. #17028

merged 1 commit into from May 25, 2017

Conversation

@bradwerth
Copy link
Contributor

bradwerth commented May 24, 2017 •
edited

MozReview-Commit-ID: 6hYIcOa86Y

https://bugzilla.mozilla.org/show_bug.cgi?id=1339629
https://reviewboard.mozilla.org/r/135314/

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented May 24, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/supports.rs, components/style/gecko/generated/bindings.rs, components/style/counter_style/mod.rs, components/style/stylesheets.rs, components/style/document_condition.rs and 3 more
  • @emilio: components/style/supports.rs, ports/geckolib/glue.rs, components/style/gecko/generated/bindings.rs, components/style/counter_style/mod.rs, components/style/stylesheets.rs and 4 more
@highfive
Copy link

highfive commented May 24, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bradwerth
Copy link
Contributor Author

bradwerth commented May 24, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2017

@bradwerth: 🔑 Insufficient privileges: Not in reviewers
@highfive highfive assigned heycam and unassigned asajeffrey May 24, 2017
@emilio
Copy link
Member

emilio commented May 24, 2017

@bors-servo r=heycam delegate+
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2017

✌️ @bradwerth can now approve this pull request
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2017

📌 Commit b56aeef has been approved by heycam
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2017

🌲 The tree is currently closed for pull requests below priority 999, this pull request will be tested once the tree is reopened
@emilio
Copy link
Member

emilio commented May 24, 2017

@bors-servo r-

Unit tests are failing:

The command "./mach build -d --verbose" exited with 101.
23.99s$ ./mach test-compiletest
   Compiling compiletest_rs v0.2.6
   Compiling style v0.0.1 (file:///home/travis/build/servo/servo/components/style)
   Compiling compiletest_helper v0.0.1 (file:///home/travis/build/servo/servo/tests/compiletest/helper)
error: no method named `deep_clone_from_gecko` found for type `&font_face::FontFaceRuleData` in the current scope
   --> /home/travis/build/servo/servo/components/style/stylesheets.rs:509:26
    |
509 |                     rule.deep_clone_from_gecko())))
    |                          ^^^^^^^^^^^^^^^^^^^^^
error: no method named `deep_clone_from_gecko` found for type `&counter_style::CounterStyleRuleData` in the current scope
   --> /home/travis/build/servo/servo/components/style/stylesheets.rs:514:26
    |
514 |                     rule.deep_clone_from_gecko())))
    |                          ^^^^^^^^^^^^^^^^^^^^^
error: aborting due to 2 previous errors
error: Could not compile `style`.
To learn more, run the command again with --verbose.
@bradwerth
Deep clone ServoStyleSheets.
Loading status checks…
31584e3 
MozReview-Commit-ID: 6hYIcOa86Y
@bzbarsky
Copy link
Contributor

bzbarsky commented May 25, 2017

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

✌️ @bradwerth can now approve this pull request
@bradwerth
Copy link
Contributor Author

bradwerth commented May 25, 2017

@bors-servo r=heycam
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

📌 Commit 31584e3 has been approved by heycam
@bzbarsky
Copy link
Contributor

bzbarsky commented May 25, 2017

@bors-servo p=5
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

⌛ Testing commit 31584e3 with merge b8146a6...
bors-servo added a commit that referenced this pull request May 25, 2017
@bors-servo
Auto merge of #17028 - bradwerth:innerClone, r=heycam
Loading status checks…
b8146a6 
Stylo: Deep clone ServoStyleSheets.

MozReview-Commit-ID: 6hYIcOa86Y

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1339629
https://reviewboard.mozilla.org/r/135314/

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17028)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

💔 Test failed - mac-rel-wpt2
@bradwerth
Copy link
Contributor Author

bradwerth commented May 25, 2017

@bors-servo retry
@bradwerth
Copy link
Contributor Author

bradwerth commented May 25, 2017

retrying after intermittents
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

⌛ Testing commit 31584e3 with merge 0d6b0da...
bors-servo added a commit that referenced this pull request May 25, 2017
@bors-servo
Auto merge of #17028 - bradwerth:innerClone, r=heycam
Loading status checks…
0d6b0da 
Stylo: Deep clone ServoStyleSheets.

MozReview-Commit-ID: 6hYIcOa86Y

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1339629
https://reviewboard.mozilla.org/r/135314/

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17028)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing 0d6b0da to master...
@bors-servo bors-servo merged commit 31584e3 into servo:master May 25, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bradwerth bradwerth deleted the bradwerth:innerClone branch May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@bradwerth @highfive @bors-servo @emilio @bzbarsky @asajeffrey @heycam
You can’t perform that action at this time.