Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rust-webvr #17031

Merged
merged 1 commit into from May 25, 2017
Merged

Update rust-webvr #17031

merged 1 commit into from May 25, 2017
+58 −13

Conversation

@MortimerGoro
Copy link
Contributor

MortimerGoro commented May 24, 2017 •
edited by jdm

Required for #16556

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented May 24, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/dom/vrdisplayevent.rs, components/script/dom/vrdisplay.rs, components/script/dom/vr.rs
  • @KiChjang: components/script/dom/vrdisplayevent.rs, components/script/dom/vrdisplay.rs, components/script/dom/vr.rs
@highfive
Copy link

highfive commented May 24, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@emilio
Copy link
Member

emilio commented May 24, 2017

Dupe of #17023... Hope the queue was faster...
@emilio emilio closed this May 24, 2017
@emilio emilio reopened this May 24, 2017
@emilio
Copy link
Member

emilio commented May 24, 2017

Ouch, missed the comment over there
@emilio
emilio reviewed May 24, 2017
View changes
Copy link
Member

emilio left a comment

The rust-webvr bump that added the enums should've probably be a breaking change... But fine. r=me
components/script/dom/vrdisplay.rs
@@ -71,7 +71,9 @@ pub struct VRDisplay {
frame_data_status: Cell<VRFrameDataStatus>,
#[ignore_heap_size_of = "channels are hard"]
frame_data_receiver: DOMRefCell<Option<IpcReceiver<Result<Vec<u8>, ()>>>>,
running_display_raf: Cell<bool>
running_display_raf: Cell<bool>,
paused: Cell<bool>,

This comment has been minimized.

Sign in to view
@emilio

emilio May 24, 2017

Member

Please add comments about how the state is managed here.

This comment has been minimized.

Sign in to view
@MortimerGoro

MortimerGoro May 24, 2017 •
edited

Author Contributor

Yes, it makes sense. I'll do breaking changes for added enums from now on.
@emilio
Copy link
Member

emilio commented May 24, 2017

@bors-servo delegate+
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2017

✌️ @MortimerGoro can now approve this pull request
@MortimerGoro MortimerGoro force-pushed the MortimerGoro:update_webvr branch from 1acbcab to 67fe59b May 24, 2017
@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented May 24, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2017

📌 Commit 67fe59b has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 24, 2017

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened
@highfive highfive assigned emilio and unassigned glennw May 24, 2017
@nox
Copy link
Member

nox commented May 24, 2017

Wait, 0.3.2 needs code change? That should have been 0.4.0 then.
@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented May 24, 2017 •
edited

@nox Yes, I didn't think about that because the API change was "just" adding new enum events. I'll do breaking changes for added enums from now on.
@nox
Copy link
Member

nox commented May 25, 2017

@MortimerGoro
Update rust-webvr
Loading status checks…
5ac106c
@MortimerGoro MortimerGoro force-pushed the MortimerGoro:update_webvr branch from 67fe59b to 5ac106c May 25, 2017
@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented May 25, 2017

You should yank that bump and publish 0.4 right now.

Done
@MortimerGoro
Copy link
Contributor Author

MortimerGoro commented May 25, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

📌 Commit 5ac106c has been approved by emilio
@nox
Copy link
Member

nox commented May 25, 2017

Perfect, thanks!
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

⌛ Testing commit 5ac106c with merge 3c267d7...
bors-servo added a commit that referenced this pull request May 25, 2017
@bors-servo
Auto merge of #17031 - MortimerGoro:update_webvr, r=emilio
Loading status checks…
3c267d7 
Update rust-webvr

<!-- Please describe your changes on the following line: -->

Required for #16556

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17031)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing 3c267d7 to master...
@bors-servo bors-servo merged commit 5ac106c into servo:master May 25, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
This was referenced May 25, 2017
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@MortimerGoro @highfive @emilio @bors-servo @nox @glennw
You can’t perform that action at this time.