Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow text to be in background shorthand #17035

Merged
merged 1 commit into from May 25, 2017
Merged

Allow text to be in background shorthand #17035

merged 1 commit into from May 25, 2017

Conversation

@upsuper
Copy link
Member

upsuper commented May 25, 2017 •
edited by larsbergstrom

Servo side change of bug 1188074.

This change is Reviewable
@upsuper
Allow text to be in background shorthand
Loading status checks…
3e51595
@highfive
Copy link

highfive commented May 25, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/shorthand/background.mako.rs
  • @emilio: components/style/properties/shorthand/background.mako.rs
@highfive
Copy link

highfive commented May 25, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper
Copy link
Member Author

upsuper commented May 25, 2017

@bors-servo r=heycam p=10
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

📌 Commit 3e51595 has been approved by heycam
@highfive highfive assigned heycam and unassigned mbrubeck May 25, 2017
@nox
Copy link
Member

nox commented May 25, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #17025
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

📌 Commit 3e51595 has been approved by nox
@highfive highfive assigned nox and unassigned heycam May 25, 2017
@nox
Copy link
Member

nox commented May 25, 2017

@bors-servo r=heycam

Hah.
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #17025
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

📌 Commit 3e51595 has been approved by heycam
@highfive highfive assigned heycam and unassigned nox May 25, 2017
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

⌛ Testing commit 3e51595 with merge 3016a03...
bors-servo added a commit that referenced this pull request May 25, 2017
@bors-servo
Auto merge of #17035 - upsuper:bug1188074, r=heycam
Loading status checks…
3016a03 
Allow text to be in background shorthand

Servo side change of [bug 1188074](https://bugzilla.mozilla.org/show_bug.cgi?id=1188074).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17035)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 25, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing 3016a03 to master...
@bors-servo bors-servo merged commit 3e51595 into servo:master May 25, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@upsuper upsuper deleted the upsuper-forks:bug1188074 branch May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heycam heycam

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@upsuper @highfive @bors-servo @nox @mbrubeck @heycam
You can’t perform that action at this time.