Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use values::generics::rect::Rect some more #17036

Merged
merged 3 commits into from May 27, 2017

Conversation

Projects
None yet
5 participants
@nox
Copy link
Member

commented May 25, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 25, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/values/specified/basic_shape.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/shorthand/serialize.mako.rs, components/style/properties/longhand/background.mako.rs and 10 more
  • @emilio: components/layout/display_list_builder.rs, components/style/properties/gecko.mako.rs, components/style/values/specified/basic_shape.rs, components/style/properties/shorthand/border.mako.rs, components/style/properties/shorthand/serialize.mako.rs and 11 more
@nox

This comment has been minimized.

@emilio

This comment has been minimized.

Copy link
Member

commented May 25, 2017

r=me, assuming geckotry comes out green.

@nox

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

Good thing I did a geckotry run, forgot the webkit prefix for background-size.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e852dba6dd1e58ea4654563420978c6c858bd1f

@nox

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 25, 2017

⌛️ Trying commit c157b5e with merge 4bc0827...

bors-servo added a commit that referenced this pull request May 25, 2017

Auto merge of #17036 - servo:derive-all-the-things, r=<try>
Use values::generics::rect::Rect some more

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17036)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 25, 2017

💔 Test failed - android

@nox nox force-pushed the derive-all-the-things branch from c157b5e to bd8d94c May 25, 2017

@nox nox force-pushed the derive-all-the-things branch from bd8d94c to 150c9df May 25, 2017

@nox

This comment has been minimized.

@nox

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

I had forgotten to call parse_non_negative instead of parse.

@nox

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

Geckotry is green.

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 25, 2017

📌 Commit 150c9df has been approved by emilio

@highfive highfive assigned emilio and unassigned metajack May 25, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 25, 2017

⌛️ Testing commit 150c9df with merge 5f8b76e0b40e7475df1d95bdc7fc913b507e4bfe...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 25, 2017

💔 Test failed - android

@nox

This comment has been minimized.

Copy link
Member Author

commented May 25, 2017

@bors-servo retry #JustAndroidThings

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 25, 2017

⌛️ Testing commit 150c9df with merge 18164a5...

bors-servo added a commit that referenced this pull request May 25, 2017

Auto merge of #17036 - servo:derive-all-the-things, r=emilio
Use values::generics::rect::Rect some more

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17036)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 25, 2017

💔 Test failed - android

@nox

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

⌛️ Testing commit 150c9df with merge 7275f65...

bors-servo added a commit that referenced this pull request May 27, 2017

Auto merge of #17036 - servo:derive-all-the-things, r=emilio
Use values::generics::rect::Rect some more

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17036)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing 7275f65 to master...

@bors-servo bors-servo merged commit 150c9df into master May 27, 2017

3 of 4 checks passed

dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.