Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #17042

Merged
merged 1 commit into from May 26, 2017
Merged

Update dependencies #17042

merged 1 commit into from May 26, 2017

Conversation

mbrubeck
Copy link
Contributor

@mbrubeck mbrubeck commented May 25, 2017

No Cargo.toml changes except base64 which is updated from 0.4.2 to 0.5.2. Does not affect stylo. No new crates in the dependency graph.


This change is Reviewable

@highfive
Copy link

Heads up! This PR modifies the following files:

  • @asajeffrey: components/webdriver_server/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @fitzgen: components/script/Cargo.toml
  • @KiChjang: components/net/Cargo.toml, components/script/Cargo.toml

@highfive highfive added the S-awaiting-review There is new code that needs to be reviewed. label May 25, 2017
@highfive
Copy link

warning Warning warning

  • These commits modify net and script code, but no tests are modified. Please consider adding a test!

@jdm
Copy link
Member

jdm commented May 25, 2017

@bors-servo: r+

@bors-servo
Copy link
Contributor

📌 Commit c58508d has been approved by jdm

@bors-servo
Copy link
Contributor

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@highfive highfive assigned jdm and unassigned glennw May 25, 2017
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-awaiting-review There is new code that needs to be reviewed. labels May 25, 2017
@bors-servo
Copy link
Contributor

⌛ Testing commit c58508d with merge 1a719a1...

bors-servo pushed a commit that referenced this pull request May 26, 2017
Update dependencies

No Cargo.toml changes except `base64` which is updated from 0.4.2 to 0.5.2.  Does not affect stylo.  No new crates in the dependency graph.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17042)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels May 26, 2017
@jdm
Copy link
Member

jdm commented May 26, 2017

@bors-servo: retry

  • git weirdness

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, windows-msvc-dev are reusable. Rebuilding only mac-rel-css, mac-rel-wpt1, mac-rel-wpt2...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label May 26, 2017
@mbrubeck
Copy link
Contributor Author

@bors-servo retry

@bors-servo
Copy link
Contributor

⚡ Previous build results for android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt2, windows-msvc-dev are reusable. Rebuilding only mac-rel-wpt1...

@bors-servo
Copy link
Contributor

💔 Test failed - mac-rel-wpt1

@highfive highfive added the S-tests-failed The changes caused existing tests to fail. label May 26, 2017
@jdm
Copy link
Member

jdm commented May 26, 2017

Something has gone very wrong with that builder.

@mbrubeck
Copy link
Contributor Author

@bors-servo
Copy link
Contributor

⌛ Testing commit c58508d with merge 0f5ccdb...

bors-servo pushed a commit that referenced this pull request May 26, 2017
Update dependencies

No Cargo.toml changes except `base64` which is updated from 0.4.2 to 0.5.2.  Does not affect stylo.  No new crates in the dependency graph.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17042)
<!-- Reviewable:end -->
@highfive highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels May 26, 2017
@bors-servo
Copy link
Contributor

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: jdm
Pushing 0f5ccdb to master...

@bors-servo bors-servo merged commit c58508d into servo:master May 26, 2017
@highfive highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants