Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (mostly optimizations). #17052

Merged
merged 1 commit into from May 29, 2017
Merged

Update WR (mostly optimizations). #17052

merged 1 commit into from May 29, 2017

Conversation

@glennw
Copy link
Member

glennw commented May 26, 2017 •
edited by larsbergstrom

  • Correctly handle degenerate border corner radii.
  • Hold glyphs and images in resource cache longer.
  • Optimize the primitive instance code.
  • Texture cache coalescing optimizations.
  • Workarounds for a couple of driver shader parsing issues.
  • Optimize vertex format sizes.

This change is Reviewable
@gw3583
Update WR (mostly optimizations).
Loading status checks…
bcb0e58 
* Correctly handle degenerate border corner radii.
* Hold glyphs and images in resource cache longer.
* Optimize the primitive instance code.
* Texture cache coalescing optimizations.
* Workarounds for a couple of driver shader parsing issues.
* Optimize vertex format sizes.
@jdm
Copy link
Member

jdm commented May 26, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 26, 2017

📌 Commit bcb0e58 has been approved by jdm
@highfive highfive assigned jdm and unassigned emilio May 26, 2017
@jdm
Copy link
Member

jdm commented May 26, 2017

@bors-servo: r-
@jdm
Copy link
Member

jdm commented May 26, 2017 

94.90s$ ./mach build -d --verbose

cargo build -v

    Updating git repository `https://github.com/servo/webrender`

error: failed to load source for a dependency on `webrender_traits`

Caused by:

  Unable to update https://github.com/servo/webrender#9cc838b7

Caused by:

  failed to fetch into /home/travis/build/servo/servo/.cargo/git/db/webrender-c3596abe1cf4f320

Caused by:

  [9/-3] Object not found - no match for id (6902f7d200ad115e5e9a95e08303db15f0f0dbba)

Build FAILED in 0:00:00
@jdm
Copy link
Member

jdm commented May 26, 2017

This might be fixed by #17040.
@glennw
Copy link
Member Author

glennw commented May 28, 2017

@jdm Is this worth retrying? Or is it going to always fail due to that CI / infra issue?
@jdm
Copy link
Member

jdm commented May 29, 2017

This should be mergeable once that PR merges.
@jdm
Copy link
Member

jdm commented May 29, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2017

📌 Commit bcb0e58 has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2017

⌛ Testing commit bcb0e58 with merge 45d8b0f...
bors-servo added a commit that referenced this pull request May 29, 2017
@bors-servo
Auto merge of #17052 - glennw:update-wr-stuff, r=jdm
Loading status checks…
45d8b0f 
Update WR (mostly optimizations).

* Correctly handle degenerate border corner radii.
* Hold glyphs and images in resource cache longer.
* Optimize the primitive instance code.
* Texture cache coalescing optimizations.
* Workarounds for a couple of driver shader parsing issues.
* Optimize vertex format sizes.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17052)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 29, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 45d8b0f to master...
@bors-servo bors-servo merged commit bcb0e58 into servo:master May 29, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
@jdm jdm mentioned this pull request May 29, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@glennw @jdm @bors-servo @emilio @highfive @gw3583
You can’t perform that action at this time.