Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set root font size when styling NAC #17057

Merged
merged 1 commit into from May 27, 2017

Conversation

Projects
None yet
6 participants
@Manishearth
Copy link
Member

commented May 26, 2017

@highfive

This comment has been minimized.

Copy link

commented May 26, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/properties.mako.rs, components/style/matching.rs
  • @emilio: components/style/properties/properties.mako.rs, components/style/matching.rs
@highfive

This comment has been minimized.

Copy link

commented May 26, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member

commented May 26, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 26, 2017

📌 Commit 9f4bb75 has been approved by emilio

@highfive highfive assigned emilio and unassigned metajack May 26, 2017

@Manishearth Manishearth force-pushed the Manishearth:nonac branch from 9f4bb75 to 9a06077 May 26, 2017

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 26, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 26, 2017

📌 Commit 9a06077 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 26, 2017

⌛️ Testing commit 9a06077 with merge 5919152...

bors-servo added a commit that referenced this pull request May 26, 2017

Auto merge of #17057 - Manishearth:nonac, r=emilio
Don't set root font size when styling NAC

try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad4acc4941dd91d10e3646ecd7fa03576fc75342

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17057)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

💔 Test failed - linux-dev

@jdm

This comment has been minimized.

Copy link
Member

commented May 27, 2017

Test-tidy failed.

Don't set root font size when styling NAC
MozReview-Commit-ID: 12CEdFLSJTh

@Manishearth Manishearth force-pushed the Manishearth:nonac branch from 9a06077 to 314d7d3 May 27, 2017

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

📌 Commit 314d7d3 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

⌛️ Testing commit 314d7d3 with merge eae7142...

bors-servo added a commit that referenced this pull request May 27, 2017

Auto merge of #17057 - Manishearth:nonac, r=emilio
Don't set root font size when styling NAC

try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad4acc4941dd91d10e3646ecd7fa03576fc75342

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17057)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

💔 Test failed - mac-rel-wpt2

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

📌 Commit 314d7d3 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

⌛️ Testing commit 314d7d3 with merge 6706c81...

bors-servo added a commit that referenced this pull request May 27, 2017

Auto merge of #17057 - Manishearth:nonac, r=emilio
Don't set root font size when styling NAC

try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=ad4acc4941dd91d10e3646ecd7fa03576fc75342

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17057)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing 6706c81 to master...

@bors-servo bors-servo merged commit 314d7d3 into servo:master May 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@Manishearth Manishearth deleted the Manishearth:nonac branch May 27, 2017

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request May 28, 2017

Bug 1341102 - Update reftest expectations for servo/servo#17057.
MozReview-Commit-ID: 6ysK45IlAEz

--HG--
extra : rebase_source : 7a952853a14c14ffa6fb63da761f774e76e8c0ca

aethanyc pushed a commit to aethanyc/gecko-dev that referenced this pull request May 28, 2017

JerryShih pushed a commit to JerryShih/gecko-dev that referenced this pull request May 30, 2017

Manishearth pushed a commit to Manishearth/gecko-dev that referenced this pull request Jun 11, 2017

brendandahl pushed a commit to brendandahl/gecko that referenced this pull request Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.