Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: Support remaning longhands #17058

Merged
merged 5 commits into from May 27, 2017

Conversation

Projects
None yet
6 participants
@Manishearth
Copy link
Member

commented May 27, 2017

@highfive

This comment has been minimized.

Copy link

commented May 27, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs, components/style/values/computed/mod.rs and 8 more
  • @emilio: components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs, components/style/values/computed/mod.rs and 8 more
@highfive

This comment has been minimized.

Copy link

commented May 27, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

(will try to land tomorrow)

}
}
<%
# This is ridiculous

This comment has been minimized.

Copy link
@nox

nox May 27, 2017

Member

Remove that.

This comment has been minimized.

Copy link
@Manishearth

Manishearth May 27, 2017

Author Member

Aw. Fine.

@Manishearth Manishearth force-pushed the Manishearth:stylo-randomprops branch from fa096f4 to defbce0 May 27, 2017

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

@bors-servo r=upsuper

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

📌 Commit defbce0 has been approved by upsuper

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

⌛️ Testing commit defbce0 with merge 9976119...

bors-servo added a commit that referenced this pull request May 27, 2017

Auto merge of #17058 - Manishearth:stylo-randomprops, r=upsuper
stylo: Support remaning longhands

r=xidorn https://bugzilla.mozilla.org/show_bug.cgi?id=1367275

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17058)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

💔 Test failed - linux-rel-css

@Manishearth Manishearth force-pushed the Manishearth:stylo-randomprops branch from defbce0 to 62e1b0d May 27, 2017

@Manishearth Manishearth force-pushed the Manishearth:stylo-randomprops branch from 62e1b0d to 1e92933 May 27, 2017

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

@bors-servo r=upsuper

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

📌 Commit 1e92933 has been approved by upsuper

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

⌛️ Testing commit 1e92933 with merge 7ccbeb8bfe8f1242c3b38a0781d4bc5e003625e3...

@Manishearth Manishearth force-pushed the Manishearth:stylo-randomprops branch from 6e76d23 to a1c82b9 May 27, 2017

@Manishearth Manishearth force-pushed the Manishearth:stylo-randomprops branch from a1c82b9 to 18771d7 May 27, 2017

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

@bors-servo r=upsuper

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

📌 Commit 18771d7 has been approved by upsuper

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

⌛️ Testing commit 18771d7 with merge b03b89a...

bors-servo added a commit that referenced this pull request May 27, 2017

Auto merge of #17058 - Manishearth:stylo-randomprops, r=upsuper
stylo: Support remaning longhands

r=xidorn https://bugzilla.mozilla.org/show_bug.cgi?id=1367275

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17058)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

💔 Test failed - android

@Manishearth Manishearth force-pushed the Manishearth:stylo-randomprops branch from 18771d7 to ccccfb9 May 27, 2017

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

@bors-servo r=emilio

infra exception
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

📌 Commit ccccfb9 has been approved by emilio

@highfive highfive assigned emilio and unassigned upsuper May 27, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

⌛️ Testing commit ccccfb9 with merge 369d5cf...

bors-servo added a commit that referenced this pull request May 27, 2017

Auto merge of #17058 - Manishearth:stylo-randomprops, r=emilio
stylo: Support remaning longhands

r=xidorn https://bugzilla.mozilla.org/show_bug.cgi?id=1367275

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17058)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: emilio
Pushing 369d5cf to master...

@bors-servo bors-servo merged commit ccccfb9 into servo:master May 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@Manishearth Manishearth deleted the Manishearth:stylo-randomprops branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.