Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support symbols() function and string value for list-style-type for stylo #17060

Merged
merged 5 commits into from May 27, 2017

Conversation

Projects
None yet
5 participants
@upsuper
Copy link
Member

commented May 27, 2017

This is the Servo side change of bug 1363596.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 27, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/properties/shorthand/list.mako.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs and 5 more
  • @emilio: components/style/properties/gecko.mako.rs, components/style/gecko/generated/structs_debug.rs, components/style/properties/shorthand/list.mako.rs, components/style/gecko/generated/structs_release.rs, components/style/gecko/generated/bindings.rs and 5 more
@highfive

This comment has been minimized.

Copy link

commented May 27, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

@bors-servo r=heycam p=10

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

📌 Commit 5f9ae73 has been approved by heycam

@highfive highfive assigned heycam and unassigned metajack May 27, 2017

@upsuper upsuper force-pushed the upsuper:bug1363596 branch from 5f9ae73 to a467455 May 27, 2017

@upsuper

This comment has been minimized.

Copy link
Member Author

commented May 27, 2017

@bors-servo r=heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

📌 Commit a467455 has been approved by heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

⌛️ Testing commit a467455 with merge 6b1f039...

bors-servo added a commit that referenced this pull request May 27, 2017

Auto merge of #17060 - upsuper:bug1363596, r=heycam
Support symbols() function and string value for list-style-type for stylo

This is the Servo side change of [bug 1363596](https://bugzilla.mozilla.org/show_bug.cgi?id=1363596).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17060)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 27, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css, mac-rel-wpt1, mac-rel-wpt2, windows-msvc-dev
Approved by: heycam
Pushing 6b1f039 to master...

@bors-servo bors-servo merged commit a467455 into servo:master May 27, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.