Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventSource: decode UTF-8 code points across network packets #17061

Merged
merged 2 commits into from May 30, 2017

Conversation

Projects
None yet
4 participants
@SimonSapin
Copy link
Member

commented May 27, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 27, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script/lib.rs, components/script/dom/textencoder.rs, components/script/Cargo.toml, components/script/body.rs, components/devtools/actors/network_event.rs and 4 more
  • @KiChjang: components/script/lib.rs, components/script/dom/textencoder.rs, components/script/Cargo.toml, components/script/body.rs, components/script/dom/eventsource.rs and 1 more
@highfive

This comment has been minimized.

Copy link

commented May 27, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
@nox

This comment has been minimized.

Copy link
Member

commented May 30, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

📌 Commit 57438cf has been approved by nox

bors-servo added a commit that referenced this pull request May 30, 2017

Auto merge of #17061 - servo:utf8, r=nox
EventSource: decode UTF-8 code points across network packets

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17061)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

⌛️ Testing commit 57438cf with merge 25d0c56...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

@bors-servo bors-servo merged commit 57438cf into master May 30, 2017

3 of 4 checks passed

dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@SimonSapin SimonSapin deleted the utf8 branch Jun 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.