Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back clipboard support #17067

Merged
merged 1 commit into from Jun 1, 2017
Merged

Bring back clipboard support #17067

merged 1 commit into from Jun 1, 2017

Conversation

@est31
Copy link
Contributor

est31 commented May 28, 2017 •
edited

Brings back clipboard support.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #17065
  • These changes fix #12805
  • There are tests for these changes OR
  • These changes do not require tests because _____
  • Testing these chances would require a full integration-style test suite, which servo currently lacks.

This change is Reviewable
@highfive
Copy link

highfive commented May 28, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @glennw (or someone else) soon.
@highfive
Copy link

highfive commented May 28, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/Cargo.toml, components/constellation/constellation.rs, components/constellation/lib.rs
  • @fitzgen: components/script/textinput.rs
  • @KiChjang: components/script/textinput.rs
@highfive
Copy link

highfive commented May 28, 2017

warning Warning warning

  • These commits modify script code, but no tests are modified. Please consider adding a test!
This was referenced May 28, 2017
Open
Merged
@nox
Copy link
Member

nox commented May 30, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2017

📌 Commit e642794 has been approved by nox
@highfive highfive assigned nox and unassigned glennw May 30, 2017
@nox
Copy link
Member

nox commented May 30, 2017

@bors-servo r-

Checking files for tidiness...
./Cargo.lock:1: duplicate versions for package `error-chain`
	The following packages depend on version 0.10.0 from 'crates.io':
		x11-clipboard
	The following packages depend on version 0.7.2 from 'crates.io':
		metadeps
@nox nox added S-fails-tidy and removed S-awaiting-merge labels May 30, 2017
@est31
Copy link
Contributor Author

est31 commented May 30, 2017

r? @nox
@nox
Copy link
Member

nox commented May 30, 2017

Needs squash.
@est31 est31 force-pushed the est31:master branch from 7b98cc5 to c1d377e May 30, 2017
@nox
Copy link
Member

nox commented May 30, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2017

📌 Commit c1d377e has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2017

⌛ Testing commit c1d377e with merge fe86f5b...
@est31
Bring back clipboard support
Loading status checks…
28b854d
@est31 est31 force-pushed the est31:master branch from c1d377e to 28b854d Jun 1, 2017
@jdm
Copy link
Member

jdm commented Jun 1, 2017

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2017

⌛ Trying commit 28b854d with merge 03e4c22...
bors-servo added a commit that referenced this pull request Jun 1, 2017
@bors-servo
Auto merge of #17067 - est31:master, r=<try>
Loading status checks…
03e4c22 
Bring back clipboard support

Brings back clipboard support.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17065
- [x] These changes fix #12805

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
- [x] Testing these chances would require a full integration-style test suite, which servo currently lacks.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@jdm
Copy link
Member

jdm commented Jun 1, 2017

@bors-servo: r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2017

📌 Commit 28b854d has been approved by jdm
@highfive highfive assigned jdm and unassigned nox Jun 1, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2017

⌛ Testing commit 28b854d with merge 9e82b31...
bors-servo added a commit that referenced this pull request Jun 1, 2017
@bors-servo
Auto merge of #17067 - est31:master, r=jdm
Loading status checks…
9e82b31 
Bring back clipboard support

Brings back clipboard support.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17065
- [x] These changes fix #12805

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
- [x] Testing these chances would require a full integration-style test suite, which servo currently lacks.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2017

💔 Test failed - linux-dev
@jdm
Copy link
Member

jdm commented Jun 1, 2017

@bors-servo: retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2017

⌛ Testing commit 28b854d with merge 12de616...
bors-servo added a commit that referenced this pull request Jun 1, 2017
@bors-servo
Auto merge of #17067 - est31:master, r=jdm
Loading status checks…
12de616 
Bring back clipboard support

Brings back clipboard support.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17065
- [x] These changes fix #12805

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
- [x] Testing these chances would require a full integration-style test suite, which servo currently lacks.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17067)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 1, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: jdm
Pushing 12de616 to master...
@bors-servo bors-servo merged commit 28b854d into servo:master Jun 1, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@atouchet atouchet mentioned this pull request Jun 2, 2017
Closed
@atouchet atouchet mentioned this pull request Jun 11, 2017
Closed
@est31 est31 mentioned this pull request Jun 20, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jdm jdm

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Bring back clipboard support
Paste not working
7 participants
@est31 @highfive @nox @bors-servo @stshine @jdm @glennw
You can’t perform that action at this time.