Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove no-op viewport code #17074

Merged
merged 1 commit into from May 29, 2017

Conversation

Projects
None yet
6 participants
@paulrouget
Copy link
Contributor

commented May 29, 2017


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #16809 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because no-op code

This change is Reviewable

@paulrouget paulrouget requested a review from glennw May 29, 2017

@paulrouget paulrouget assigned glennw and unassigned pcwalton May 29, 2017

@emilio

This comment has been minimized.

Copy link
Member

commented May 29, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 29, 2017

📌 Commit b0afc26 has been approved by emilio

@highfive highfive assigned emilio and unassigned glennw May 29, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 29, 2017

⌛️ Testing commit b0afc26 with merge 86dcd53...

bors-servo added a commit that referenced this pull request May 29, 2017

Auto merge of #17074 - paulrouget:remove_viewport, r=emilio
remove no-op viewport code

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16809 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because no-op code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17074)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 29, 2017

@bors-servo bors-servo merged commit b0afc26 into servo:master May 29, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.