Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"javascript:" urls: execute in correct global scope #17083

Merged
merged 8 commits into from Sep 9, 2017
+154 −93
Merged

"javascript:" urls: execute in correct global scope #17083

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa3e9ab
"javascript:" urls: run in correct global
danielj41 Aug 20, 2017
af41769
"javascript:" urls: add web-platform-test
danielj41 May 29, 2017
ff786a0
"javascript:" urls: clean up after aborting a page load
danielj41 Aug 28, 2017
fc23cb1
"javascript:" urls: move test to correct location
danielj41 Aug 28, 2017
5d28dd6
"javascript:" urls: clean up js evaluation code
danielj41 Aug 28, 2017
6ae6031
"javascript:" urls: evaluate in iframe src attribute
danielj41 Aug 29, 2017
709cd3a
"javascript:" urls: remove unnecessary block
danielj41 Sep 8, 2017
452db05
"javascript:" urls: update test expectations
danielj41 Sep 9, 2017
File filter...
Filter file types
Clear filters
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Prev Next
Loading status checks…

"javascript:" urls: add web-platform-test

  • Loading branch information
@danielj41
danielj41 committed Aug 23, 2017
commit af41769d70e134fa7013127604e8ecbf7ace24a5
10 tests/wpt/metadata/MANIFEST.json
View file
Open in desktop
{}
]
],
"url/a-element-href-javascript.html": [
[
"/url/a-element-href-javascript.html",
{}
]
],
"url/a-element-origin-xhtml.xhtml": [
[
"/url/a-element-origin-xhtml.xhtml",
"3dacc2783865ba292f20b72bc4c3942de521d9b0",
"support"
],
"url/a-element-href-javascript.html": [
"567d16dde294a2f3e75fdb8139d1af9a8c73e0fc",

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Aug 24, 2017

Member

Be sure to run ./mach update-manifest after moving the test (and making any changes to it).
"testharness"
],
"url/a-element-origin-xhtml.xhtml": [
"56019fd2d3870324ba412e3e0c602bad3b90ef49",
"testharness"
28 tests/wpt/web-platform-tests/url/a-element-href-javascript.html
View file
Open in desktop
@@ -0,0 +1,28 @@
<!doctype html>

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Aug 24, 2017

Member

This file belongs in web-platform-tests/html/browsers/navigating-across-documents instead; tests are organized according to the layout of the specification that they are testing.

This comment has been minimized.

Sign in to view
Copy link
@danielj41

danielj41 Aug 29, 2017 •
edited

Author Contributor

Thank you for the review! Fixed in fc23cb1
<meta charset=utf-8>
<script src=/resources/testharness.js></script>
<script src=/resources/testharnessreport.js></script>

<script>
var linkStatus = 'link not clicked';

function changeStatus() {
linkStatus = 'link has been clicked';
}
</script>

<a id="javascript-link" href="javascript:changeStatus()">link</a>

<script>
setup({explicit_done:true});

document.querySelector("#javascript-link").click();

step_timeout(function() {

This comment has been minimized.

Sign in to view
Copy link
@jdm

jdm Aug 24, 2017

Member

Let's do this instead:

<script>
function changeStatus() {
  t.done();
}

var t = async_test(function(t) {
  document.querySelector("#javascript-link").click();
}, "javascript: scheme urls should be executed in current global scope");
</script>

This comment has been minimized.

Sign in to view
Copy link
@danielj41

danielj41 Aug 29, 2017

Author Contributor

Fixed in fc23cb1
test(function() {
assert_equals(linkStatus, "link has been clicked");
}, "javascript: scheme urls should be executed in correct global scope");

done();
});
</script>
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.