Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `./mach upload-nightly macbrew` #17085

Merged

Conversation

Projects
None yet
5 participants
@aneeshusa
Copy link
Member

commented May 29, 2017

Fix a few issues with the Homebrew repository updating.
Follow-up to #16565; should finish off #17045.

Lightly smoke-tested locally this time.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because they will be tested on the builders

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 29, 2017

Heads up! This PR modifies the following files:

  • @wafflespeanut: python/servo/package_commands.py, python/servo/servo-binary-formula.rb.in
@@ -442,7 +460,9 @@ def update_brew(package, timestamp):

brew_version = timestamp.strftime('%Y.%m.%d')

with tempfile.TemporaryDirectory(prefix='homebrew-servo') as tmp_dir:
with TemporaryDirectory(prefix='homebrew-servo') as tmp_dir:
print(tmp_dir)

This comment has been minimized.

Copy link
@larsbergstrom

larsbergstrom May 30, 2017

Contributor

Is this intentionally left in, or was it for debugging output? Either with fix or left if it was intentional, r=me.

This comment has been minimized.

Copy link
@aneeshusa

aneeshusa May 30, 2017

Author Member

Good catch, fixed.

@larsbergstrom larsbergstrom assigned larsbergstrom and unassigned nox May 30, 2017

@aneeshusa aneeshusa force-pushed the aneeshusa:fix-mach-upload-nightly-for-macbrew branch from 2f58ed8 to 45c499d May 30, 2017

@aneeshusa

This comment has been minimized.

Copy link
Member Author

commented May 30, 2017

@bors-servo r=larsbergstrom

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

📌 Commit 45c499d has been approved by larsbergstrom

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

⌛️ Testing commit 45c499d with merge 011a7ad...

bors-servo added a commit that referenced this pull request May 30, 2017

Auto merge of #17085 - aneeshusa:fix-mach-upload-nightly-for-macbrew,…
… r=larsbergstrom

Fix `./mach upload-nightly macbrew`

<!-- Please describe your changes on the following line: -->
Fix a few issues with the Homebrew repository updating.
Follow-up to #16565; should finish off #17045.

Lightly smoke-tested locally this time.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they will be tested on the builders

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17085)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

@bors-servo bors-servo merged commit 45c499d into servo:master May 30, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.