Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSSOM support of @import rule for stylo #17086

Merged
merged 4 commits into from May 30, 2017

Conversation

Projects
None yet
5 participants
@upsuper
Copy link
Member

commented May 29, 2017

This is the Servo side change of bug 1352968.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 29, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko/generated/bindings.rs, components/style/gecko/generated/structs_debug.rs, components/style/stylesheets.rs, components/style/gecko/generated/structs_release.rs
  • @emilio: components/style/gecko/generated/bindings.rs, ports/geckolib/glue.rs, components/style/gecko/generated/structs_debug.rs, components/style/stylesheets.rs, components/style/gecko/generated/structs_release.rs
@highfive

This comment has been minimized.

Copy link

commented May 29, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify style code, but no tests are modified. Please consider adding a test!
@upsuper

This comment has been minimized.

Copy link
Member Author

commented May 29, 2017

@bors-servo r=heycam

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 29, 2017

📌 Commit 571d4c2 has been approved by heycam

@highfive highfive assigned heycam and unassigned pcwalton May 29, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 29, 2017

⌛️ Testing commit 571d4c2 with merge 0857435...

bors-servo added a commit that referenced this pull request May 29, 2017

Auto merge of #17086 - upsuper:bug1352968, r=heycam
Add CSSOM support of @import rule for stylo

This is the Servo side change of [bug 1352968](https://bugzilla.mozilla.org/show_bug.cgi?id=1352968).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17086)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

@bors-servo bors-servo merged commit 571d4c2 into servo:master May 30, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@upsuper upsuper deleted the upsuper:bug1352968 branch May 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.