Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support currentColor for fill and stroke. #17089

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
4 participants
@hiikezoe
Copy link
Contributor

commented May 30, 2017

This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1368376


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes do not require tests because it's for stylo

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 30, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/values/specified/mod.rs
  • @emilio: components/style/values/specified/mod.rs
@highfive

This comment has been minimized.

Copy link

commented May 30, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@hiikezoe

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2017

@bors-servo r=xidorn.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

📌 Commit 33e16fe has been approved by xidorn.

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

⌛️ Testing commit 33e16fe with merge 9e89b0a...

bors-servo added a commit that referenced this pull request May 30, 2017

Auto merge of #17089 - hiikezoe:current-color-for-fill-and-stroke, r=…
…xidorn.

Support currentColor for fill and stroke.

<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1368376

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's for stylo
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

@bors-servo bors-servo merged commit 33e16fe into servo:master May 30, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@hiikezoe hiikezoe deleted the hiikezoe:current-color-for-fill-and-stroke branch May 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.