Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylo - Bug 1365674: Simulate compute value failure for tests #17093

Merged

Conversation

Projects
None yet
6 participants
@ferjm
Copy link
Member

commented May 30, 2017

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors

https://bugzilla.mozilla.org/show_bug.cgi?id=1365674


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 30, 2017

Heads up! This PR modifies the following files:

@ferjm

This comment has been minimized.

Copy link
Member Author

commented May 30, 2017

@hiikezoe

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

@bors-servo delegate+

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

✌️ @ferjm can now approve this pull request

@ferjm

This comment has been minimized.

Copy link
Member Author

commented May 30, 2017

@bors-servo r=hiikezoe

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

📌 Commit e61a231 has been approved by hiikezoe

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

⌛️ Testing commit e61a231 with merge bb6553a...

bors-servo added a commit that referenced this pull request May 30, 2017

Auto merge of #17093 - ferjm:bug1365674.simulate.compute.value.failur…
…e, r=hiikezoe

Stylo - Bug 1365674: Simulate compute value failure for tests

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

https://bugzilla.mozilla.org/show_bug.cgi?id=1365674

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17093)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

💔 Test failed - linux-dev

@jdm

This comment has been minimized.

Copy link
Member

commented May 30, 2017

   Compiling geckoservo v0.0.1 (file:///home/servo/buildbot/slave/linux-dev/build/ports/geckolib)
error: no field `mSimulateComputeValuesFailure` on type `&style::gecko_bindings::structs::PropertyValuePair`
    --> glue.rs:2431:43
     |
2431 |     id.as_shorthand().is_ok() && property.mSimulateComputeValuesFailure
     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error
@hiikezoe

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

@ferjm you need to update generated binding files in components/style/gecko/generated/.
You can get the files from try builds. target.stylo-bindings.zip is the file.

@ferjm ferjm force-pushed the ferjm:bug1365674.simulate.compute.value.failure branch from e61a231 to ebfb18c May 31, 2017

@ferjm

This comment has been minimized.

Copy link
Member Author

commented May 31, 2017

@bors-servo r=hiikezoe

  • Updated bindings
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

📌 Commit ebfb18c has been approved by hiikezoe

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

⌛️ Testing commit ebfb18c with merge 36a2281...

bors-servo added a commit that referenced this pull request May 31, 2017

Auto merge of #17093 - ferjm:bug1365674.simulate.compute.value.failur…
…e, r=hiikezoe

Stylo - Bug 1365674: Simulate compute value failure for tests

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

https://bugzilla.mozilla.org/show_bug.cgi?id=1365674

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17093)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

💔 Test failed - android

@ferjm

This comment has been minimized.

Copy link
Member Author

commented May 31, 2017

@bors-servo r=hiikezoe

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #17107
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

📌 Commit ebfb18c has been approved by hiikezoe

@jdm

This comment has been minimized.

Copy link
Member

commented May 31, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

⌛️ Testing commit ebfb18c with merge 0932f34...

bors-servo added a commit that referenced this pull request May 31, 2017

Auto merge of #17093 - ferjm:bug1365674.simulate.compute.value.failur…
…e, r=hiikezoe

Stylo - Bug 1365674: Simulate compute value failure for tests

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

https://bugzilla.mozilla.org/show_bug.cgi?id=1365674

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17093)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

💔 Test failed - mac-dev-unit

@ferjm

This comment has been minimized.

Copy link
Member Author

commented May 31, 2017

@bors-servo: retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

⌛️ Testing commit ebfb18c with merge 71eb672...

bors-servo added a commit that referenced this pull request May 31, 2017

Auto merge of #17093 - ferjm:bug1365674.simulate.compute.value.failur…
…e, r=hiikezoe

Stylo - Bug 1365674: Simulate compute value failure for tests

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

https://bugzilla.mozilla.org/show_bug.cgi?id=1365674

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17093)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

@bors-servo bors-servo merged commit ebfb18c into servo:master May 31, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@ferjm ferjm deleted the ferjm:bug1365674.simulate.compute.value.failure branch Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.