Stylo - Bug 1365674: Simulate compute value failure for tests #17093

ferjm · 2017-05-30T08:50:21Z

./mach build -d does not report any errors
./mach test-tidy does not report any errors

https://bugzilla.mozilla.org/show_bug.cgi?id=1365674

This change is

highfive · 2017-05-30T08:50:25Z

Heads up! This PR modifies the following files:

@emilio: ports/geckolib/glue.rs

ferjm · 2017-05-30T08:57:44Z

r? @hiikezoe

hiikezoe · 2017-05-30T08:59:48Z

@bors-servo delegate+

bors-servo · 2017-05-30T08:59:49Z

✌️ @ferjm can now approve this pull request

ferjm · 2017-05-30T09:37:22Z

@bors-servo r=hiikezoe

bors-servo · 2017-05-30T09:37:23Z

📌 Commit e61a231 has been approved by hiikezoe

bors-servo · 2017-05-30T20:02:29Z

⌛ Testing commit e61a231 with merge bb6553a...


        Auto merge of #17093 - ferjm:bug1365674.simulate.compute.value.failur…

…e, r=hiikezoe Stylo - Bug 1365674: Simulate compute value failure for tests - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors https://bugzilla.mozilla.org/show_bug.cgi?id=1365674  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17093)

bors-servo · 2017-05-30T20:25:16Z

💔 Test failed - linux-dev

jdm · 2017-05-30T21:50:21Z

   Compiling geckoservo v0.0.1 (file:///home/servo/buildbot/slave/linux-dev/build/ports/geckolib)
error: no field `mSimulateComputeValuesFailure` on type `&style::gecko_bindings::structs::PropertyValuePair`
    --> glue.rs:2431:43
     |
2431 |     id.as_shorthand().is_ok() && property.mSimulateComputeValuesFailure
     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

error: aborting due to previous error

hiikezoe · 2017-05-30T22:06:29Z

@ferjm you need to update generated binding files in components/style/gecko/generated/.
You can get the files from try builds. target.stylo-bindings.zip is the file.


        Stylo - Bug 1365674: Simulate compute value failure for tests


        Update gecko bindings

ferjm · 2017-05-31T09:11:24Z

@bors-servo r=hiikezoe

Updated bindings

bors-servo · 2017-05-31T09:11:24Z

📌 Commit ebfb18c has been approved by hiikezoe

bors-servo · 2017-05-31T09:11:28Z

⌛ Testing commit ebfb18c with merge 36a2281...


        Auto merge of #17093 - ferjm:bug1365674.simulate.compute.value.failur…

…e, r=hiikezoe Stylo - Bug 1365674: Simulate compute value failure for tests - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors https://bugzilla.mozilla.org/show_bug.cgi?id=1365674  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17093)

bors-servo · 2017-05-31T09:29:27Z

💔 Test failed - android

ferjm · 2017-05-31T13:13:30Z

@bors-servo r=hiikezoe

bors-servo · 2017-05-31T13:13:30Z

💡 This pull request was already approved, no need to approve it again.

This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
There's another pull request that is currently being tested, blocking this pull request: #17107

bors-servo · 2017-05-31T13:13:30Z

📌 Commit ebfb18c has been approved by hiikezoe

jdm · 2017-05-31T13:17:08Z

@bors-servo: retry

servo/saltfs#684

bors-servo · 2017-05-31T13:18:04Z

⌛ Testing commit ebfb18c with merge 0932f34...


        Auto merge of #17093 - ferjm:bug1365674.simulate.compute.value.failur…

…e, r=hiikezoe Stylo - Bug 1365674: Simulate compute value failure for tests - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors https://bugzilla.mozilla.org/show_bug.cgi?id=1365674  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17093)

bors-servo · 2017-05-31T13:33:20Z

💔 Test failed - mac-dev-unit

ferjm · 2017-05-31T13:40:38Z

@bors-servo: retry

bors-servo · 2017-05-31T17:03:52Z

⌛ Testing commit ebfb18c with merge 71eb672...


        Auto merge of #17093 - ferjm:bug1365674.simulate.compute.value.failur…

…e, r=hiikezoe Stylo - Bug 1365674: Simulate compute value failure for tests - [X] `./mach build -d` does not report any errors - [X] `./mach test-tidy` does not report any errors https://bugzilla.mozilla.org/show_bug.cgi?id=1365674  --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17093)

bors-servo · 2017-05-31T19:24:00Z

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: hiikezoe
Pushing 71eb672 to master...

highfive assigned KiChjang May 30, 2017

highfive added the S-awaiting-review label May 30, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels May 30, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels May 30, 2017

ferjm added 2 commits May 30, 2017

Stylo - Bug 1365674: Simulate compute value failure for tests

7f5d62c

Update gecko bindings

Loading status checks…

ebfb18c

ferjm force-pushed the ferjm:bug1365674.simulate.compute.value.failure branch from e61a231 to ebfb18c May 31, 2017

highfive added S-awaiting-review and removed S-tests-failed labels May 31, 2017

highfive added S-awaiting-merge and removed S-awaiting-review labels May 31, 2017

highfive removed the S-awaiting-merge label May 31, 2017

highfive added the S-tests-failed label May 31, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels May 31, 2017

highfive added S-tests-failed and removed S-awaiting-merge labels May 31, 2017

highfive added S-awaiting-merge and removed S-tests-failed labels May 31, 2017

bors-servo merged commit ebfb18c into servo:master May 31, 2017
3 checks passed

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

continuous-integration/travis-ci/pr The Travis CI build passed
Details

homu Test successful
Details

highfive removed the S-awaiting-merge label May 31, 2017

ferjm deleted the ferjm:bug1365674.simulate.compute.value.failure branch Jun 7, 2017

servo / servo

Stylo - Bug 1365674: Simulate compute value failure for tests #17093

Stylo - Bug 1365674: Simulate compute value failure for tests #17093

ferjm commented May 30, 2017 •

edited by larsbergstrom

highfive commented May 30, 2017

ferjm commented May 30, 2017

hiikezoe commented May 30, 2017

bors-servo commented May 30, 2017

ferjm commented May 30, 2017

bors-servo commented May 30, 2017

bors-servo commented May 30, 2017

bors-servo commented May 30, 2017

jdm commented May 30, 2017

hiikezoe commented May 30, 2017

ferjm commented May 31, 2017

bors-servo commented May 31, 2017

bors-servo commented May 31, 2017

bors-servo commented May 31, 2017

ferjm commented May 31, 2017

bors-servo commented May 31, 2017

bors-servo commented May 31, 2017

jdm commented May 31, 2017

bors-servo commented May 31, 2017

bors-servo commented May 31, 2017

ferjm commented May 31, 2017

bors-servo commented May 31, 2017

bors-servo commented May 31, 2017

servo / servo

Join GitHub today

Stylo - Bug 1365674: Simulate compute value failure for tests #17093

Stylo - Bug 1365674: Simulate compute value failure for tests #17093

Conversation

ferjm commented May 30, 2017 • edited by larsbergstrom

highfive commented May 30, 2017

ferjm commented May 30, 2017

hiikezoe commented May 30, 2017

bors-servo commented May 30, 2017

ferjm commented May 30, 2017

bors-servo commented May 30, 2017

bors-servo commented May 30, 2017

bors-servo commented May 30, 2017

jdm commented May 30, 2017

hiikezoe commented May 30, 2017

ferjm commented May 31, 2017

bors-servo commented May 31, 2017

bors-servo commented May 31, 2017

bors-servo commented May 31, 2017

ferjm commented May 31, 2017

bors-servo commented May 31, 2017

bors-servo commented May 31, 2017

jdm commented May 31, 2017

bors-servo commented May 31, 2017

bors-servo commented May 31, 2017

ferjm commented May 31, 2017

bors-servo commented May 31, 2017

bors-servo commented May 31, 2017

ferjm commented May 30, 2017 •

edited by larsbergstrom