Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor a few CSS properties #17095

Merged
merged 3 commits into from May 31, 2017
Merged

Refactor a few CSS properties #17095

merged 3 commits into from May 31, 2017
+271 −275

Conversation

@nox
Copy link
Member

nox commented May 30, 2017 •
edited by larsbergstrom

This change is Reviewable
@nox
Clean up some <time> properties
b42aaf2
@highfive
Copy link

highfive commented May 30, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/effects.mako.rs, components/style/values/specified/transform.rs, components/style/values/specified/mod.rs, components/style/values/generics/transform.rs, components/style/values/computed/mod.rs and 4 more
  • @emilio: components/style/properties/longhand/effects.mako.rs, components/style/values/specified/transform.rs, components/style/values/specified/mod.rs, components/style/values/generics/transform.rs, components/style/values/computed/mod.rs and 4 more
@nox
Copy link
Member Author

nox commented May 30, 2017

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3ab8b33176a3b58691303a84d9b1d8a30ede14e
@emilio
emilio reviewed May 30, 2017
View changes
components/style/values/specified/transform.rs Outdated
return Ok(Self::new(x_origin, y_origin, depth));
}
let y_origin = OriginComponent::Center;
if let Ok(x_origin) = input.try(|i| OriginComponent::parse(context, i)) {

This comment has been minimized.

Sign in to view
@emilio

emilio May 30, 2017

Member

How can this succeed now if it failed in the branch above? Am I missing something obvious here?
@nox nox force-pushed the derive-all-the-things branch from 456b6f2 to ae7f9d4 May 30, 2017
@nox
Copy link
Member Author

nox commented May 30, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2017

📌 Commit ae7f9d4 has been approved by emilio
@highfive highfive assigned emilio and unassigned cbrewster May 30, 2017
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2017

⌛ Testing commit ae7f9d4 with merge 1007cb1...
bors-servo added a commit that referenced this pull request May 30, 2017
@bors-servo
Auto merge of #17095 - servo:derive-all-the-things, r=emilio
Loading status checks…
1007cb1 
Refactor a few CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17095)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 30, 2017

💔 Test failed - linux-rel-wpt
nox added 2 commits May 30, 2017
@nox
Make use of generics for transform-origin
5d70580 
This allows us to preserve keywords during serialisation.
@nox
Silence a warning in style unit tests
Loading status checks…
851b5e2
@nox nox force-pushed the derive-all-the-things branch from ae7f9d4 to 851b5e2 May 31, 2017
@nox
Copy link
Member Author

nox commented May 31, 2017

@bors-servo r=emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2017

📌 Commit 851b5e2 has been approved by emilio
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2017

⌛ Testing commit 851b5e2 with merge 399d99a...
bors-servo added a commit that referenced this pull request May 31, 2017
@bors-servo
Auto merge of #17095 - servo:derive-all-the-things, r=emilio
Loading status checks…
399d99a 
Refactor a few CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17095)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2017

💔 Test failed - android
@nox
Copy link
Member Author

nox commented May 31, 2017

@bors-servo retry #17107
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2017

⌛ Testing commit 851b5e2 with merge 5c311197e1327ef83aa8d154783bedd44f7e06d3...
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2017

💔 Test failed - mac-rel-wpt4
@jdm
Copy link
Member

jdm commented May 31, 2017

@bors-servo: retry

  • ssl timeout
@nox
Copy link
Member Author

nox commented May 31, 2017

@bors-servo p=1
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2017

⌛ Testing commit 851b5e2 with merge cd22fc6...
bors-servo added a commit that referenced this pull request May 31, 2017
@bors-servo
Auto merge of #17095 - servo:derive-all-the-things, r=emilio
Loading status checks…
cd22fc6 
Refactor a few CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17095)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented May 31, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: emilio
Pushing cd22fc6 to master...
@bors-servo bors-servo merged commit 851b5e2 into master May 31, 2017
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the derive-all-the-things branch May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@emilio emilio

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@nox @highfive @bors-servo @jdm @emilio @cbrewster
You can’t perform that action at this time.