Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor a few CSS properties #17095

Merged
merged 3 commits into from May 31, 2017

Conversation

Projects
None yet
6 participants
@nox
Copy link
Member

commented May 30, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented May 30, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/effects.mako.rs, components/style/values/specified/transform.rs, components/style/values/specified/mod.rs, components/style/values/generics/transform.rs, components/style/values/computed/mod.rs and 4 more
  • @emilio: components/style/properties/longhand/effects.mako.rs, components/style/values/specified/transform.rs, components/style/values/specified/mod.rs, components/style/values/generics/transform.rs, components/style/values/computed/mod.rs and 4 more
@nox

This comment has been minimized.

return Ok(Self::new(x_origin, y_origin, depth));
}
let y_origin = OriginComponent::Center;
if let Ok(x_origin) = input.try(|i| OriginComponent::parse(context, i)) {

This comment has been minimized.

Copy link
@emilio

emilio May 30, 2017

Member

How can this succeed now if it failed in the branch above? Am I missing something obvious here?

@nox nox force-pushed the derive-all-the-things branch from 456b6f2 to ae7f9d4 May 30, 2017

@nox

This comment has been minimized.

Copy link
Member Author

commented May 30, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

📌 Commit ae7f9d4 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

⌛️ Testing commit ae7f9d4 with merge 1007cb1...

bors-servo added a commit that referenced this pull request May 30, 2017

Auto merge of #17095 - servo:derive-all-the-things, r=emilio
Refactor a few CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17095)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

💔 Test failed - linux-rel-wpt

nox added some commits May 30, 2017

Make use of generics for transform-origin
This allows us to preserve keywords during serialisation.

@nox nox force-pushed the derive-all-the-things branch from ae7f9d4 to 851b5e2 May 31, 2017

@nox

This comment has been minimized.

Copy link
Member Author

commented May 31, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

📌 Commit 851b5e2 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

⌛️ Testing commit 851b5e2 with merge 399d99a...

bors-servo added a commit that referenced this pull request May 31, 2017

Auto merge of #17095 - servo:derive-all-the-things, r=emilio
Refactor a few CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17095)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

💔 Test failed - android

@nox

This comment has been minimized.

Copy link
Member Author

commented May 31, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

⌛️ Testing commit 851b5e2 with merge 5c311197e1327ef83aa8d154783bedd44f7e06d3...

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

💔 Test failed - mac-rel-wpt4

@jdm

This comment has been minimized.

Copy link
Member

commented May 31, 2017

@bors-servo: retry

  • ssl timeout
@nox

This comment has been minimized.

Copy link
Member Author

commented May 31, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

⌛️ Testing commit 851b5e2 with merge cd22fc6...

bors-servo added a commit that referenced this pull request May 31, 2017

Auto merge of #17095 - servo:derive-all-the-things, r=emilio
Refactor a few CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17095)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented May 31, 2017

@bors-servo bors-servo merged commit 851b5e2 into master May 31, 2017

3 of 4 checks passed

dependency-ci Failed dependency checks
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@nox nox deleted the derive-all-the-things branch May 31, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.