Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRun custom element tests #17101
Run custom element tests #17101
Conversation
|
I noticed that there was no metadata for these tests, not even to disable them... Are these not ran by |
cbrewster
force-pushed the
cbrewster:custom_element_tests
branch
from
cda034e
to
8ad590c
|
r? @jdm |
|
Yeah, you need to add an entry to include.ini as well. |
cbrewster
force-pushed the
cbrewster:custom_element_tests
branch
from
8ad590c
to
9d36ea5
|
@bors-servo: r+ |
|
|
Run custom element tests I would like to have these enabled so its easier to see newly passing tests in subsequent PRs. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17101) <!-- Reviewable:end -->
|
|
|
We usually don't just enable tests if we don't actually have commits fixing them in the same PR. |
|
See for example #5839. |
|
There is precedent for enabling tests separately from the work that starts addressing them. |
Ok! Disregard me then. :) |
|
@bors-servo: retry |
Run custom element tests I would like to have these enabled so its easier to see newly passing tests in subsequent PRs. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17101) <!-- Reviewable:end -->
|
|
cbrewster commentedMay 30, 2017
•
edited by larsbergstrom
I would like to have these enabled so its easier to see newly passing tests in subsequent PRs.
This change is