Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove cssparser dependency from msg. #17111
Merged
Conversation
|
Needs a Cargo.lock update, and the commit message should be changed to say "cssparser" instead of "heapsize". r=mbrubeck with those fixed. |
|
@bors-servo: r=mbrubeck |
|
|
mbrubeck
changed the title
bors-servo
added a commit
that referenced
this pull request
May 31, 2017
Remove cssparser dependency from msg. This removes a bunch of unnecessary rebuilds when modifying rust-cssparser. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17111) <!-- Reviewable:end -->
|
|
|
@bors-servo: retry |
bors-servo
added a commit
that referenced
this pull request
Jun 1, 2017
Remove cssparser dependency from msg. This removes a bunch of unnecessary rebuilds when modifying rust-cssparser. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17111) <!-- Reviewable:end -->
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 9, 2017
Remove cssparser dependency from msg. This applies the change from #17111 once more since it was reverted by an incorrect rebase. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17255) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedMay 31, 2017
•
edited by larsbergstrom
This removes a bunch of unnecessary rebuilds when modifying rust-cssparser.
This change is