Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement custom element registry #17112

Merged
merged 3 commits into from Jun 5, 2017
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Fix custom element registry define test

The test relies on DOM elements with ids beind added
as properties of the window. Servo does not do this, and
this is not a best practice.
  • Loading branch information
cbrewster committed Jun 5, 2017
commit 1800da779c49b30f5b20d6e238bfe430e3377338
"testharness"
],
"custom-elements/custom-element-registry/define.html": [
"724060b276a1f3254fd226e329631005ec5a5e87",
"4f3d4da1aae8efab035a4b951147904d71e7de3b",
"testharness"
],
"custom-elements/disconnected-callbacks.html": [
@@ -12,6 +12,7 @@
// https://html.spec.whatwg.org/multipage/scripting.html#element-definition

// Use window from iframe to isolate the test.
const iframe = document.getElementById("iframe");
const testWindow = iframe.contentDocument.defaultView;
const customElements = testWindow.customElements;

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.