Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust nightly #17149

Merged
merged 1 commit into from Jun 9, 2017

Conversation

@nox
Copy link
Member

nox commented Jun 3, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

highfive commented Jun 3, 2017

Heads up! This PR modifies the following files:

  • @fitzgen: components/script_plugins/unrooted_must_root.rs
  • @KiChjang: components/script_plugins/unrooted_must_root.rs, components/net/lib.rs, components/net_traits/image/base.rs, components/net_traits/image/base.rs, components/net/image_cache.rs and 2 more
@highfive

This comment has been minimized.

Copy link

highfive commented Jun 3, 2017

warning Warning warning

  • These commits modify net code, but no tests are modified. Please consider adding a test!
@emilio

This comment has been minimized.

Copy link
Member

emilio commented Jun 3, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 3, 2017

📌 Commit 9842227 has been approved by emilio

@highfive highfive assigned emilio and unassigned asajeffrey Jun 3, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 3, 2017

⌛️ Testing commit 9842227 with merge bf6534e...

bors-servo added a commit that referenced this pull request Jun 3, 2017
Update both Rust versions

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17149)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 3, 2017

💔 Test failed - linux-rel-wpt

@nox

This comment has been minimized.

Copy link
Member Author

nox commented Jun 4, 2017

@jdm Does that ring a bell?

@jdm

This comment has been minimized.

Copy link
Member

jdm commented Jun 4, 2017

No.

@nox

This comment has been minimized.

Copy link
Member Author

nox commented Jun 4, 2017

@nox

This comment has been minimized.

Copy link
Member Author

nox commented Jun 4, 2017

@bors-servo r- try

@nox

This comment has been minimized.

Copy link
Member Author

nox commented Jun 4, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 4, 2017

⌛️ Trying commit 9842227 with merge f6129bf...

bors-servo added a commit that referenced this pull request Jun 4, 2017
Update both Rust versions

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17149)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 4, 2017

💔 Test failed - linux-rel-css

@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented Jun 5, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 5, 2017

⌛️ Trying commit 9842227 with merge 815c47a...

bors-servo added a commit that referenced this pull request Jun 5, 2017
Update both Rust versions

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17149)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 5, 2017

💔 Test failed - linux-rel-css

@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented Jun 5, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 5, 2017

⌛️ Trying commit 9842227 with merge cc9c71c...

bors-servo added a commit that referenced this pull request Jun 5, 2017
Update both Rust versions

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17149)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 5, 2017

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Jun 5, 2017

@bors-servo clean

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Jun 5, 2017

@bors-servo clean try-

@nox

This comment has been minimized.

Copy link
Member Author

nox commented Jun 6, 2017

This is ok to land now, right?

@nox

This comment has been minimized.

Copy link
Member Author

nox commented Jun 7, 2017

@SimonSapin I think you said we shouldn't raise minimum version to 1.17 or something like that?

@SimonSapin

This comment has been minimized.

Copy link
Member

SimonSapin commented Jun 7, 2017

Firefox's mach currently checks for 1.15.1+:

http://searchfox.org/mozilla-central/rev/20963d7269b1b14d455f47bc0260d0653015bf84/build/moz.configure/rust.configure#58

This is changed by filing a bug like https://bugzilla.mozilla.org/show_bug.cgi?id=1337153 and CCing @rillian. I don't know if there's a policy for how long we want to support a release before raising the requirement.

@rillian

This comment has been minimized.

Copy link
Contributor

rillian commented Jun 7, 2017

Firefox's only policy is that release Firefox be build with stable Rust. Otherwise I've just tried to balance the interests of those wanting new features vs those wanting less churn in their dev environment.

@nox nox force-pushed the rustup branch from 9842227 to 4c8a0f0 Jun 9, 2017
@nox nox changed the title Update both Rust versions Update Rust nightly Jun 9, 2017
@nox

This comment has been minimized.

Copy link
Member Author

nox commented Jun 9, 2017

I removed the Rust stable commit given mozilla-central forces us to stay in the past.

@emilio

This comment has been minimized.

Copy link
Member

emilio commented Jun 9, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 9, 2017

📌 Commit 4c8a0f0 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 9, 2017

⌛️ Testing commit 4c8a0f0 with merge 9656341...

bors-servo added a commit that referenced this pull request Jun 9, 2017
Update Rust nightly

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17149)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

bors-servo commented Jun 9, 2017

@bors-servo bors-servo merged commit 4c8a0f0 into master Jun 9, 2017
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Checking Dependencies
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@SimonSapin SimonSapin deleted the rustup branch Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants
You can’t perform that action at this time.