Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive the most trivial ToCss implementations πŸŒ‹ #17152

Merged
merged 1 commit into from Jun 4, 2017

Conversation

@nox
Copy link
Member

commented Jun 4, 2017

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jun 4, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/inherited_text.mako.rs, components/style/values/specified/align.rs, components/style/values/mod.rs, components/style/values/generics/basic_shape.rs, components/style/values/computed/length.rs and 11 more
  • @emilio: components/style/properties/longhand/inherited_text.mako.rs, components/style/values/specified/align.rs, components/style/values/mod.rs, components/style/values/generics/basic_shape.rs, components/style/values/computed/length.rs and 11 more
@highfive

This comment has been minimized.

Copy link

commented Jun 4, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@highfive highfive assigned emilio and unassigned glennw Jun 4, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2017

βŒ›οΈ Trying commit b9ded92 with merge ce54b26...

bors-servo added a commit that referenced this pull request Jun 4, 2017
Derive the most trivial ToCss implementations πŸŒ‹
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2017

πŸ’” Test failed - linux-dev

For now, all variants get serialised as the space-separated serialisations
of their fields. Unit variants are not supported.
@emilio
emilio approved these changes Jun 4, 2017
Copy link
Member

left a comment

r=me, with a green GeckoTry :)

@nox nox force-pushed the derive-all-the-things branch from b9ded92 to c4f1d64 Jun 4, 2017
@highfive highfive removed the S-tests-failed label Jun 4, 2017
@nox

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2017

@nox

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2017

Gecko try run is happy.

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2017

πŸ“Œ Commit c4f1d64 has been approved by emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2017

βŒ›οΈ Testing commit c4f1d64 with merge 942fce3...

bors-servo added a commit that referenced this pull request Jun 4, 2017
Derive the most trivial ToCss implementations πŸŒ‹

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17152)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2017

@bors-servo bors-servo merged commit c4f1d64 into master Jun 4, 2017
3 of 4 checks passed
3 of 4 checks passed
dependency-ci Checking Dependencies
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.