Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the initial disk image size for mac packages. #17161

Merged
merged 1 commit into from Jun 6, 2017
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

Set the initial disk image size for mac packages.

Various stackoverflow answers suggest that setting an initial size can avoid errors while resizing the disk during the process of creating it.
  • Loading branch information
jdm committed Jun 5, 2017
commit e62f98d10031964f54dbcfedd699ac6786f8d234
@@ -274,7 +274,11 @@ def package(self, release=False, dev=False, android=None, debug=False, debugger=
os.remove(dmg_path)

try:
subprocess.check_call(['hdiutil', 'create', '-volname', 'Servo', dmg_path, '-srcfolder', dir_to_dmg])
subprocess.check_call(['hdiutil', 'create',
'-volname', 'Servo',
'-megabytes', '900',
dmg_path,
'-srcfolder', dir_to_dmg])
except subprocess.CalledProcessError as e:
print("Packaging MacOS dmg exited with return value %d" % e.returncode)
return e.returncode
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.