Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mach bootstrap for changes to wpt harness path in gecko #17163

Merged
merged 1 commit into from Jun 5, 2017

Conversation

@jgraham
Copy link
Contributor

jgraham commented Jun 5, 2017

Gecko is now using the wpt harness under the wpt tools directory
rather than a copy in an adjacent directory. Therefore the path to the
requirements files, and the required model paths, have changed.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #__ (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because it only affects the mach bootstrap script

This change is Reviewable

Gecko is now using the wpt harness under the wpt tools directory
rather than a copy in an adjacent directory. Therefore the path to the
requirements files, and the required model paths, have changed.
@highfive
Copy link

highfive commented Jun 5, 2017

Heads up! This PR modifies the following files:

@jdm
Copy link
Member

jdm commented Jun 5, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2017

📌 Commit 06cdf7b has been approved by jdm

@highfive highfive assigned jdm and unassigned glennw Jun 5, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2017

Testing commit 06cdf7b with merge a36edb9...

bors-servo added a commit that referenced this pull request Jun 5, 2017
Update mach bootstrap for changes to wpt harness path in gecko

Gecko is now using the wpt harness under the wpt tools directory
rather than a copy in an adjacent directory. Therefore the path to the
requirements files, and the required model paths, have changed.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it only affects the mach bootstrap script

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17163)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2017

💔 Test failed - linux-rel-wpt

@jdm
Copy link
Member

jdm commented Jun 5, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Jun 5, 2017

@bors-servo bors-servo merged commit 06cdf7b into servo:master Jun 5, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.