Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count number of braces on a line when checking spec links in test-tidy #17193

Merged
merged 1 commit into from Jun 8, 2017

Conversation

Projects
None yet
5 participants
@asajeffrey
Copy link
Member

commented Jun 6, 2017

Allow more than one brace per line when checking spec links in test-tidy.

We had problems caused by if unsafe { ... } {.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes have tests.

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jun 6, 2017

Heads up! This PR modifies the following files:

@asajeffrey

This comment has been minimized.

Copy link
Member Author

commented Jun 6, 2017

@jdm

This comment has been minimized.

Copy link
Member

commented Jun 6, 2017

Can you add a test to python/tidy/servo_tidy_tests/rust_tidy.rs and test_tidy.py?

@jdm

This comment has been minimized.

Copy link
Member

commented Jun 7, 2017

Looks good.

@asajeffrey asajeffrey force-pushed the asajeffrey:test-tidy-brace-count branch from 2332bbb to 1270080 Jun 7, 2017

@asajeffrey

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2017

This kicked up a couple of issues

  • We should skip attributes as well as comments when searching for spec links.
  • There were some missing spec links in components/script/dom/webglrenderingcontext.rs.
@asajeffrey

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2017

📌 Commit 1270080 has been approved by jdm

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2017

⌛️ Testing commit 1270080 with merge 07b0770...

bors-servo added a commit that referenced this pull request Jun 7, 2017

Auto merge of #17193 - asajeffrey:test-tidy-brace-count, r=jdm
Count number of braces on a line when checking spec links in test-tidy

<!-- Please describe your changes on the following line: -->

Allow more than one brace per line when checking spec links in test-tidy.

We had problems caused  by `if unsafe { ... } {`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes have tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17193)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

@bors-servo bors-servo merged commit 1270080 into servo:master Jun 8, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.