Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support interpolation between currentcolor and numeric color #17219

Merged
merged 10 commits into from Jun 8, 2017

Conversation

Projects
None yet
6 participants
@upsuper
Copy link
Member

commented Jun 8, 2017

This is the Servo side change of bug 1345709.


This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jun 8, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/gecko_bindings/sugar/ns_css_shadow_item.rs, components/style/values/specified/color.rs, components/style/properties/longhand/background.mako.rs, components/style/properties/gecko.mako.rs, components/style/properties/longhand/text.mako.rs and 23 more
  • @KiChjang: components/script/dom/element.rs
  • @fitzgen: components/script/dom/element.rs
  • @emilio: components/layout/display_list_builder.rs, components/style/gecko_bindings/sugar/ns_css_shadow_item.rs, ports/geckolib/glue.rs, components/style/values/specified/color.rs, components/style/properties/longhand/background.mako.rs and 29 more
@highfive

This comment has been minimized.

Copy link

commented Jun 8, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
@upsuper

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2017

@bors-servo r=Manishearth,birtles

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

📌 Commit 8d8d873 has been approved by Manishearth,birtles

@upsuper

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2017

@upsuper

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2017

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

⌛️ Trying commit 8d8d873 with merge d9c1e88...

bors-servo added a commit that referenced this pull request Jun 8, 2017

Auto merge of #17219 - upsuper:currentcolor, r=<try>
Support interpolation between currentcolor and numeric color

This is the Servo side change of [bug 1345709](https://bugzilla.mozilla.org/show_bug.cgi?id=1345709).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17219)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

💔 Test failed - mac-rel-css2

@upsuper upsuper force-pushed the upsuper:currentcolor branch from 8d8d873 to 5c643ad Jun 8, 2017

@upsuper

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2017

@bors-servo r=Manishearth p=1

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

📌 Commit 5c643ad has been approved by Manishearth

@upsuper

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2017

@bors-servo r=Manishearth,birtles

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: #17192
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

📌 Commit 5c643ad has been approved by Manishearth,birtles

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

⌛️ Testing commit 5c643ad with merge 24e944a...

bors-servo added a commit that referenced this pull request Jun 8, 2017

Auto merge of #17219 - upsuper:currentcolor, r=Manishearth,birtles
Support interpolation between currentcolor and numeric color

This is the Servo side change of [bug 1345709](https://bugzilla.mozilla.org/show_bug.cgi?id=1345709).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17219)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: Manishearth,birtles
Pushing 24e944a to master...

@bors-servo bors-servo merged commit 5c643ad into servo:master Jun 8, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@upsuper upsuper deleted the upsuper:currentcolor branch Jun 8, 2017

@@ -0,0 +1,44 @@
--- components/style/values/specified/mod.rs
+++ components/style/values/specified/mod.rs

This comment has been minimized.

Copy link
@emilio

emilio Jun 8, 2017

Member

This file should have not landed :(

emilio added a commit to emilio/servo that referenced this pull request Jun 8, 2017

Remove file accidentally added in servo#17219.
And prevent it from happening again.

emilio added a commit to emilio/servo that referenced this pull request Jun 8, 2017

Remove file accidentally added in servo#17219.
And prevent it from happening again.

emilio added a commit to emilio/servo that referenced this pull request Jun 8, 2017

Remove file accidentally added in servo#17219.
And prevent it from happening again.

bors-servo added a commit that referenced this pull request Jun 8, 2017

Auto merge of #17233 - emilio:rej, r=bzbarsky
Remove file accidentally added in #17219.

And prevent it from happening again.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17233)
<!-- Reviewable:end -->

jyc added a commit to jyc/servo that referenced this pull request Jun 16, 2017

Remove file accidentally added in servo#17219.
And prevent it from happening again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.