Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revalidation selectors when pseudo-elements are involved. #17225

Merged
merged 1 commit into from Jun 8, 2017

Conversation

@bzbarsky
Copy link
Contributor

commented Jun 8, 2017


  • There are tests for these changes OR
  • These changes do not require tests because I am adding a Gecko test for them

This change is Reviewable

@highfive

This comment has been minimized.

Copy link

commented Jun 8, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/sharing/mod.rs, components/style/stylist.rs
  • @emilio: components/style/sharing/mod.rs, components/style/stylist.rs
@highfive

This comment has been minimized.

Copy link

commented Jun 8, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@bzbarsky

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2017

@bors-servo r=emilio

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

📌 Commit 537cf52 has been approved by emilio

@highfive highfive assigned emilio and unassigned KiChjang Jun 8, 2017
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

⌛️ Testing commit 537cf52 with merge 3d4d13f...

bors-servo added a commit that referenced this pull request Jun 8, 2017
Fix revalidation selectors when pseudo-elements are involved.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1371112

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because I am adding a Gecko test for them

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17225)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

💔 Test failed - mac-rel-wpt2

@jdm

This comment has been minimized.

Copy link
Member

commented Jun 8, 2017

That is #17230.

@bzbarsky

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2017

@bors-servo retry

@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

⌛️ Testing commit 537cf52 with merge 3616b8f...

bors-servo added a commit that referenced this pull request Jun 8, 2017
Fix revalidation selectors when pseudo-elements are involved.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1371112

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because I am adding a Gecko test for them

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17225)
<!-- Reviewable:end -->
@bors-servo

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

@bors-servo bors-servo merged commit 537cf52 into servo:master Jun 8, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.