Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: make fill-opacity animatable #17227

Merged
merged 1 commit into from Jun 8, 2017
Merged

stylo: make fill-opacity animatable #17227

merged 1 commit into from Jun 8, 2017

Conversation

@chenpighead
Copy link
Contributor

chenpighead commented Jun 8, 2017 •
edited

This is just the servo part change. The test part will be landed in gecko directly.

Gecko bug: Bug 1369624

This change is Reviewable
@chenpighead
Bug 1369624 - stylo: make fill-opacity animatable.
Loading status checks…
a21605a 
MozReview-Commit-ID: 4iUSBtEYXuR
@highfive
Copy link

highfive commented Jun 8, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/inherited_svg.mako.rs
  • @emilio: components/style/properties/longhand/inherited_svg.mako.rs
@highfive
Copy link

highfive commented Jun 8, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@chenpighead
Copy link
Contributor Author

chenpighead commented Jun 8, 2017

@bors-servo r? @BorisChiou
@aethanyc
Copy link
Contributor

aethanyc commented Jun 8, 2017 •
edited

@bors-servo delegate+ @chenpighead
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

✌️ @chenpighead can now approve this pull request
1 similar comment
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

✌️ @chenpighead can now approve this pull request
@chenpighead
Copy link
Contributor Author

chenpighead commented Jun 8, 2017

@bors-servo r=boris
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

📌 Commit a21605a has been approved by boris
@chenpighead
Copy link
Contributor Author

chenpighead commented Jun 8, 2017

stylo try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f4ff527bff7c
@chenpighead chenpighead changed the title Bug 1369624 - stylo: make fill-opacity animatable stylo: make fill-opacity animatable Jun 8, 2017
@chenpighead
Copy link
Contributor Author

chenpighead commented Jun 8, 2017

@bors-servo try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

⌛ Trying commit a21605a with merge f2fc21e...
bors-servo added a commit that referenced this pull request Jun 8, 2017
@bors-servo
Auto merge of #17227 - chenpighead:stylo-fill-opacity-animatable, r=<…
Loading status checks…
f2fc21e 
…try>

stylo: make fill-opacity animatable

This is just the servo part change. The test part will be landed in gecko directly.

Gecko bug: [Bug 1369624](https://bugzilla.mozilla.org/show_bug.cgi?id=1369624)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17227)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

💔 Test failed - mac-rel-wpt2
@jdm
Copy link
Member

jdm commented Jun 8, 2017

That is #17230.
@chenpighead
Copy link
Contributor Author

chenpighead commented Jun 8, 2017

@bors-servo retry #17230
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

⌛ Trying commit a21605a with merge a4255a9...
bors-servo added a commit that referenced this pull request Jun 8, 2017
@bors-servo
Auto merge of #17227 - chenpighead:stylo-fill-opacity-animatable, r=<…
Loading status checks…
a4255a9 
…try>

stylo: make fill-opacity animatable

This is just the servo part change. The test part will be landed in gecko directly.

Gecko bug: [Bug 1369624](https://bugzilla.mozilla.org/show_bug.cgi?id=1369624)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17227)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved=boris try=True
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

⌛ Testing commit a21605a with merge 574f737...
bors-servo added a commit that referenced this pull request Jun 8, 2017
@bors-servo
Auto merge of #17227 - chenpighead:stylo-fill-opacity-animatable, r=b…
Loading status checks…
574f737 
…oris

stylo: make fill-opacity animatable

This is just the servo part change. The test part will be landed in gecko directly.

Gecko bug: [Bug 1369624](https://bugzilla.mozilla.org/show_bug.cgi?id=1369624)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17227)
<!-- Reviewable:end -->
@bors-servo bors-servo mentioned this pull request Jun 8, 2017
Merged
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: boris
Pushing 574f737 to master...
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward
@jdm
Copy link
Member

jdm commented Jun 8, 2017

@bors-servo: try- retry
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

⌛ Testing commit a21605a with merge 0dc7190...
bors-servo added a commit that referenced this pull request Jun 8, 2017
@bors-servo
Auto merge of #17227 - chenpighead:stylo-fill-opacity-animatable, r=b…
Loading status checks…
0dc7190 
…oris

stylo: make fill-opacity animatable

This is just the servo part change. The test part will be landed in gecko directly.

Gecko bug: [Bug 1369624](https://bugzilla.mozilla.org/show_bug.cgi?id=1369624)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17227)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 8, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: boris
Pushing 0dc7190 to master...
@bors-servo bors-servo merged commit a21605a into servo:master Jun 8, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mbrubeck mbrubeck

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@chenpighead @highfive @aethanyc @bors-servo @jdm @mbrubeck
You can’t perform that action at this time.