Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -vv through mach to cargo #17237

Closed
wants to merge 1 commit into from
Closed

Pass -vv through mach to cargo #17237

wants to merge 1 commit into from

Conversation

@CodenameLambda
Copy link

CodenameLambda commented Jun 8, 2017 •
edited

This change fixes the issue #17231 (passing -vv to ./mach build ... only passes -v to cargo).

But this introduces another pontential issue, as you can now pass -vv and -v at the same time. But I do not expect this to be a real problem, especially since cargo doesn't care.

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #17231 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because the changes are really simple.

This change is Reviewable
@CodenameLambda
Create build_commands.py
Loading status checks…
0a6b893 
This change fixes the issue #17231 (passing `-vv` to `./mach build ...` only passes `-v` to `cargo`).

But this introduces another pontential issue, as you can now pass `-vv` and `-v` at the same time. But I do not expect this to be a real problem, especially since `cargo` doesn't care.
@highfive
Copy link

highfive commented Jun 8, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @KiChjang (or someone else) soon.
@highfive
Copy link

highfive commented Jun 8, 2017

Heads up! This PR modifies the following files:
@CodenameLambda CodenameLambda changed the title Fixed issue Fixed issue #17231 Jun 8, 2017
@jdm jdm changed the title Fixed issue #17231 Pass -vv through mach to cargo Jun 8, 2017
@emilio
emilio approved these changes Jun 12, 2017
View changes
Copy link
Member

emilio left a comment

Looks fine, I went through the mach code and there isn't an obvious way to implement -vv in a way that does a counter or something like that.

Could you reword your commit? Right now the title is "Create build_commands.py', which isn't really descriptive of the change.
python/servo/build_commands.py
@@ -221,6 +224,8 @@ def build(self, target=None, release=False, dev=False, jobs=None,
opts += ["-j", jobs]
if verbose:

This comment has been minimized.

Sign in to view
@emilio

emilio Jun 12, 2017

Member

should this check if verbose and not very_verbose?

This comment has been minimized.

Sign in to view
@emilio

emilio Jun 12, 2017

Member

Oh, you mentioned it in the commit message, then this sounds fine.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 21, 2017

☔ The latest upstream changes (presumably #17822) made this pull request unmergeable. Please resolve the merge conflicts.
@KiChjang
Copy link
Member

KiChjang commented Dec 7, 2017

Closing due to inactivity.
@KiChjang KiChjang closed this Dec 7, 2017
@KiChjang KiChjang mentioned this pull request Dec 7, 2017
Closed
@tigercosmos
Copy link
Collaborator

tigercosmos commented Dec 22, 2017

@emilio is this change OK?
I though I could rebase it and fix #17231
@jdm
Copy link
Member

jdm commented Dec 22, 2017

I believe the change is fine; it just needs a different commit message.
@tigercosmos tigercosmos mentioned this pull request Dec 23, 2017
Merged
3 of 5 tasks complete
bors-servo added a commit that referenced this pull request Dec 24, 2017
@bors-servo
Auto merge of #19633 - tigercosmos:vv, r=emilio
Loading status checks…
11a25e3 
pass -vv through mach to cargo

<!-- Please describe your changes on the following line: -->
base on #17237, which is reviewed by emilio and jdm.
just need to rename commit and rebase

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17231 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19633)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 24, 2017
@bors-servo
Auto merge of #19633 - tigercosmos:vv, r=emilio
Loading status checks…
23351f0 
pass -vv through mach to cargo

<!-- Please describe your changes on the following line: -->
base on #17237, which is reviewed by emilio and jdm.
just need to rename commit and rebase

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17231 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19633)
<!-- Reviewable:end -->
bors-servo added a commit that referenced this pull request Dec 24, 2017
@bors-servo
Auto merge of #19633 - tigercosmos:vv, r=emilio
Loading status checks…
7c07f31 
pass -vv through mach to cargo

<!-- Please describe your changes on the following line: -->
base on #17237, which is reviewed by emilio and jdm.
just need to rename commit and rebase

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17231 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19633)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilio emilio

Assignees

@KiChjang KiChjang

Labels
S-needs-code-changes S-needs-rebase
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

The build tool passes -vv to cargo as -v
7 participants
@CodenameLambda @highfive @bors-servo @KiChjang @tigercosmos @jdm @emilio
You can’t perform that action at this time.