Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -vv through mach to cargo #17237

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -167,15 +167,18 @@ class MachCommands(CommandBase):
@CommandArgument('--verbose', '-v',
action='store_true',
help='Print verbose output')
@CommandArgument('--very-verbose', '-vv',
action='store_true',
help='Print very verbose output')
@CommandArgument('params', nargs='...',
help="Command-line arguments to be passed through to Cargo")
@CommandArgument('--with-debug-assertions',
default=None,
action='store_true',
help='Enable debug assertions in release')
def build(self, target=None, release=False, dev=False, jobs=None,
features=None, android=None, verbose=False, debug_mozjs=False, params=None,
with_debug_assertions=False):
features=None, android=None, verbose=False, very_verbose=False,
debug_mozjs=False, params=None, with_debug_assertions=False):
if android is None:
android = self.config["build"]["android"]
features = features or self.servo_features()
@@ -221,6 +224,8 @@ def build(self, target=None, release=False, dev=False, jobs=None,
opts += ["-j", jobs]
if verbose:

This comment has been minimized.

@emilio

emilio Jun 12, 2017

Member

should this check if verbose and not very_verbose?

This comment has been minimized.

@emilio

emilio Jun 12, 2017

Member

Oh, you mentioned it in the commit message, then this sounds fine.

opts += ["-v"]
if very_verbose:
opts += ["-vv"]

if android:
target = self.config["android"]["target"]
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.