Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parent climb hierarchy in send_frame_tree #17248

Merged
merged 1 commit into from Jun 9, 2017
Merged

Fix parent climb hierarchy in send_frame_tree #17248

merged 1 commit into from Jun 9, 2017

Conversation

@cbrewster
Copy link
Member

cbrewster commented Jun 9, 2017 •
edited by larsbergstrom

  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #17246 (github issue number if applicable).
  • There are tests for these changes OR
  • These changes do not require tests because _____

This change is Reviewable
@highfive
Copy link

highfive commented Jun 9, 2017

Heads up! This PR modifies the following files:

  • @asajeffrey: components/constellation/constellation.rs
@cbrewster
Copy link
Member Author

cbrewster commented Jun 9, 2017

Mozbrowser strikes again! Is it worth adding a reftest?
r? @asajeffrey
@cbrewster
Properly climb parent hierarchy in send_frame_tree
Loading status checks…
fc0854c
@cbrewster cbrewster force-pushed the cbrewster:fix_the_chrome branch from b6da1b2 to fc0854c Jun 9, 2017
@asajeffrey
Copy link
Member

asajeffrey commented Jun 9, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2017

📌 Commit fc0854c has been approved by asajeffrey
@jonathandturner
Copy link

jonathandturner commented Jun 9, 2017

@asajeffrey - this is a different fix than you recommended. Same effect, I take it?
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2017

⌛ Testing commit fc0854c with merge 1fe7043...
bors-servo added a commit that referenced this pull request Jun 9, 2017
@bors-servo
Auto merge of #17248 - cbrewster:fix_the_chrome, r=asajeffrey
Loading status checks…
1fe7043 
Fix parent climb hierarchy in send_frame_tree

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17246 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17248)
<!-- Reviewable:end -->
@asajeffrey asajeffrey mentioned this pull request Jun 9, 2017
Closed
@cbrewster
Copy link
Member Author

cbrewster commented Jun 9, 2017

@jonathandturner yeah they behave the same. @asajeffrey's version sets browsing_context_id on every iteration, mine waits until we reach the top of the hierarchy to set it.
@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
Approved by: asajeffrey
Pushing 1fe7043 to master...
@bors-servo bors-servo merged commit fc0854c into servo:master Jun 9, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@asajeffrey asajeffrey

Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

bhtml no longer showing navigation/url bar
5 participants
@cbrewster @highfive @asajeffrey @bors-servo @jonathandturner
You can’t perform that action at this time.