Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upPseudo element new #1725
Pseudo element new #1725
Conversation
highfive
commented
Feb 21, 2014
|
|
|
||
| #[inline] | ||
| fn after_style<'a>(&'a self) -> &'a Arc<ComputedValues> { | ||
| self.get_before_css_select_results() |
This comment has been minimized.
This comment has been minimized.
|
Rebase. and We do not use |
|
@jdm r? |
hoppipolla-critic-bot
commented
Feb 23, 2014
|
Critic review: https://critic.hoppipolla.co.uk/r/864 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
|
I am reviewing on Critic, and half complete. |
|
Critic review is finished. |
|
If you push further changes, please make sure they are additional commits on top of your existing ones so they do not cause Critic to break. |
|
@jdm Thank you for your review. :) |
|
@jdm Wow, Removed 'AbstractNode'. I'll try again implement for pseudo node. |
hyunjunekim commentedFeb 21, 2014
Hi, This is pseudo node. We take effort to make simple.
Step 1. Create Pseudo Node which are before or after.
Step 2 - 1. If Before, Insert Pseudo Node in Current Node Data.
- 2. If After and exist last child, Insert Pseudo Node in Last Child Node Data(next_after_sibling)
- 3. If After and not have child, Insert Pseudo Node in Current Node data.
Step 3 -1 If exist Before when call first_child function, return before node after link first_child, after or not.
- 2 If only exit after, return after
- 3 If don't have any pseudo element, return first_child of current node.
Step 4 - 1 If exist next_after_sibling when call next_sibling function, return next_after_sibling node
- 2 If not have next_after_sibling, return next_sibling of current node.