Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudo element new #1725

Closed
wants to merge 4 commits into from
Closed

Conversation

@hyunjunekim
Copy link
Contributor

hyunjunekim commented Feb 21, 2014

Hi, This is pseudo node. We take effort to make simple.

Step 1. Create Pseudo Node which are before or after.
Step 2 - 1. If Before, Insert Pseudo Node in Current Node Data.
- 2. If After and exist last child, Insert Pseudo Node in Last Child Node Data(next_after_sibling)
- 3. If After and not have child, Insert Pseudo Node in Current Node data.
Step 3 -1 If exist Before when call first_child function, return before node after link first_child, after or not.
- 2 If only exit after, return after
- 3 If don't have any pseudo element, return first_child of current node.
Step 4 - 1 If exist next_after_sibling when call next_sibling function, return next_after_sibling node
- 2 If not have next_after_sibling, return next_sibling of current node.

@highfive
Copy link

highfive commented Feb 21, 2014

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify layout code, but no reftests are modified. Please consider adding a reftest!
  • @hyunjunekim, please confirm that src/test/html/acid1.html and your favourite wikipedia page still render correctly!

#[inline]
fn after_style<'a>(&'a self) -> &'a Arc<ComputedValues> {
self.get_before_css_select_results()

This comment has been minimized.

@jdm

jdm Feb 21, 2014

Member

after

parkjaeman and others added 3 commits Jan 10, 2014
Conflicts:

	src/components/main/layout/construct.rs
	src/components/main/layout/wrapper.rs
	src/components/script/dom/node.rs
	src/components/util/slot.rs
@sammykim
Copy link
Contributor

sammykim commented Feb 21, 2014

Rebase. and We do not use fn before_style and fn after_style anymore.

@hyunjunekim
Copy link
Contributor Author

hyunjunekim commented Feb 22, 2014

@jdm r?

@jdm jdm closed this Feb 23, 2014
@jdm jdm reopened this Feb 23, 2014
@hoppipolla-critic-bot
Copy link

hoppipolla-critic-bot commented Feb 23, 2014

Critic review: https://critic.hoppipolla.co.uk/r/864

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@jdm
Copy link
Member

jdm commented Feb 23, 2014

I am reviewing on Critic, and half complete.

@jdm
Copy link
Member

jdm commented Feb 24, 2014

Critic review is finished.

@jdm
Copy link
Member

jdm commented Feb 24, 2014

If you push further changes, please make sure they are additional commits on top of your existing ones so they do not cause Critic to break.

@hyunjunekim
Copy link
Contributor Author

hyunjunekim commented Feb 24, 2014

@jdm Thank you for your review. :)

@hyunjunekim
Copy link
Contributor Author

hyunjunekim commented Feb 27, 2014

@jdm Wow, Removed 'AbstractNode'. I'll try again implement for pseudo node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.