Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: make {stop, flood}-opacity animatable #17251

Merged

Conversation

@chenpighead
Copy link
Contributor

chenpighead commented Jun 9, 2017

This is just the servo part change. The test part will be landed in gecko directly.

Gecko bug: Bug 1360133


This change is Reviewable

MozReview-Commit-ID: GzNs36TjZ4E
@highfive
Copy link

highfive commented Jun 9, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/properties/longhand/svg.mako.rs
  • @emilio: components/style/properties/longhand/svg.mako.rs
@highfive
Copy link

highfive commented Jun 9, 2017

warning Warning warning

  • These commits modify style code, but no tests are modified. Please consider adding a test!
@chenpighead
Copy link
Contributor Author

chenpighead commented Jun 9, 2017

@chenpighead
Copy link
Contributor Author

chenpighead commented Jun 9, 2017

@bors-servo r=hiro

@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2017

@chenpighead: 🔑 Insufficient privileges: Not in reviewers

@hiikezoe
Copy link
Contributor

hiikezoe commented Jun 9, 2017

@bors-servo delegate+

@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2017

✌️ @chenpighead can now approve this pull request

@chenpighead
Copy link
Contributor Author

chenpighead commented Jun 9, 2017

How strange... I should've been in the list of servo operator.... :(
@bors-servo r=hiro

@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2017

📌 Commit e9cbeee has been approved by hiro

@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2017

Testing commit e9cbeee with merge 2439672...

bors-servo added a commit that referenced this pull request Jun 9, 2017
…e, r=hiro

stylo: make {stop, flood}-opacity animatable

This is just the servo part change. The test part will be landed in gecko directly.

Gecko bug: [Bug 1360133](https://bugzilla.mozilla.org/show_bug.cgi?id=1360133)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17251)
<!-- Reviewable:end -->
@chenpighead
Copy link
Contributor Author

chenpighead commented Jun 9, 2017

@jdm , hi, does this mean that the change is not deployed yet? Is there anything that I should've done to make it work?

@bors-servo
Copy link
Contributor

bors-servo commented Jun 9, 2017

@bors-servo bors-servo merged commit e9cbeee into servo:master Jun 9, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.