Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pack bloom filter hashes better and save a word on Rule #17281

Merged
merged 6 commits into from Jun 12, 2017
Prev

Add a size_of test for RuleNode.

MozReview-Commit-ID: Id6iedlK5tg
  • Loading branch information
bholley committed Jun 12, 2017
commit 2d412d4e3af742fce0621de797f4109fe2fa8213
@@ -10,7 +10,7 @@ use style::applicable_declarations::ApplicableDeclarationBlock;
use style::data::{ComputedStyle, ElementData, ElementStyles};
use style::gecko::selector_parser as real;
use style::properties::ComputedValues;
use style::rule_tree::StrongRuleNode;
use style::rule_tree::{RuleNode, StrongRuleNode};

#[test]
fn size_of_selectors_dummy_types() {
@@ -39,6 +39,10 @@ size_of_test!(test_size_of_property_declaration, style::properties::PropertyDecl

size_of_test!(test_size_of_application_declaration_block, ApplicableDeclarationBlock, 24);

// FIXME(bholley): This can shrink with a little bit of work.
// See https://github.com/servo/servo/issues/17280
size_of_test!(test_size_of_rule_node, RuleNode, 96);

// This is huge, but we allocate it on the stack and then never move it,
// we only pass `&mut SourcePropertyDeclaration` references around.
size_of_test!(test_size_of_parsed_declaration, style::properties::SourcePropertyDeclaration, 704);
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.