New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pack bloom filter hashes better and save a word on Rule #17281
Merged
+253
−98
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cf982d1
Shift by KEY_SIZE instead of something larger.
bholley 6e3e7b2
Pack the fourth ancestor hash into the upper byte of the first three …
bholley 3afab14
Make source_order u32 and shrink Rule.
bholley 0caad2f
Use even fewer bits for source order and shrink ApplicableDeclaration…
bholley a98fff1
Hoist ApplicableDeclaration{Block,List} into a separate file.
bholley 2d412d4
Add a size_of test for RuleNode.
bholley File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.
Shift by KEY_SIZE instead of something larger.
Currently all Gecko and Servo do the KEY_SHIFT thing, but there's no reason we need to follow that here. See https://bugzilla.mozilla.org/show_bug.cgi?id=1371949#c10 MozReview-Commit-ID: CqNi7r9e5s0
- Loading branch information
commit cf982d17b9ef0966c77d1161ed1346dde543136e
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This comment seems incorrect to me. Based on a cursory reading of this PR, it seems that the hashes are 24 bits, leaving 8 bits unused in a 32 bit word.