Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upstylo: support font-variant shorthand #17310
Merged
+119
−85
Conversation
Avoid early returning Err() in parsers, so we could let the the caller of the parsers to handle the rest of input, and return error if it requires parsing entirely. The point is let returning Err() stay inside input.try(), so we can count on input.try() to restore the position when parsing invalid idents. From gecko bug: Bug 1356134 (https://bugzilla.mozilla.org/show_bug.cgi?id=1356134)
highfive
commented
Jun 14, 2017
highfive
commented
Jun 14, 2017
|
|
|
@bors-servo r=xidorn |
|
@chenpighead: |
|
@bors-servo r+ |
|
|
|
No idea why I still can't talk to @bors-servo.... :/ |
chenpighead
force-pushed the
chenpighead:stylo-font-variant
branch
from
6b587e5
to
d55af14
We still count on Bug 1356124 to fix font-variant-alternates longhand, so we can get font-variant shorthand work properly. Some comments about Bug 1356124 have been removed, since this shorthand code should just work once we fix Bug 1356124. From gecko bug: Bug 1356134 (https://bugzilla.mozilla.org/show_bug.cgi?id=1356134)
chenpighead
force-pushed the
chenpighead:stylo-font-variant
branch
from
d55af14
to
c7c7538
|
@bors-servo delegate+ |
|
|
|
@bors-servo r=xidorn |
|
|
bors-servo
added a commit
that referenced
this pull request
Jun 14, 2017
stylo: support font-variant shorthand From gecko bug: [Bug 1356134](https://bugzilla.mozilla.org/show_bug.cgi?id=1356134) <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17310) <!-- Reviewable:end -->
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
chenpighead commentedJun 14, 2017
•
edited by larsbergstrom
From gecko bug: Bug 1356134
This change is