Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stylo: support font-variant shorthand #17310

Merged
merged 2 commits into from Jun 14, 2017

Commits on Jun 14, 2017

  1. stylo: make font-variant-* longhands parsing more tolerant.

    Avoid early returning Err() in parsers, so we could let the the caller
    of the parsers to handle the rest of input, and return error if it requires
    parsing entirely.
    
    The point is let returning Err() stay inside input.try(), so we can count
    on input.try() to restore the position when parsing invalid idents.
    
    From gecko bug: Bug 1356134 (https://bugzilla.mozilla.org/show_bug.cgi?id=1356134)
    chenpighead committed Jun 14, 2017
  2. stylo: support font-variant shorthand.

    We still count on Bug 1356124 to fix font-variant-alternates longhand, so we
    can get font-variant shorthand work properly.
    
    Some comments about Bug 1356124 have been removed, since this shorthand code
    should just work once we fix Bug 1356124.
    
    From gecko bug: Bug 1356134 (https://bugzilla.mozilla.org/show_bug.cgi?id=1356134)
    chenpighead committed Jun 14, 2017
You can’t perform that action at this time.