Skip to content

/ servo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump serde to 1.0 #17325

Closed
wants to merge 1 commit into from
Closed

Bump serde to 1.0 #17325

wants to merge 1 commit into from

Conversation

@Eijebong
Copy link
Member

Eijebong commented Jun 14, 2017 •
edited by larsbergstrom

Update serde to 1.0

  • ./mach build -d does not report any errors

  • ./mach test-tidy does not report any errors

  • These changes fix #16556

  • These changes do not require tests because it's a dependency bump

This change is Reviewable
@highfive
Copy link

highfive commented Jun 14, 2017

Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @nox (or someone else) soon.
@highfive
Copy link

highfive commented Jun 14, 2017

Heads up! This PR modifies the following files:

  • @bholley: components/style/Cargo.toml
  • @jgraham: components/webdriver_server/Cargo.toml
  • @emilio: components/style/Cargo.toml, components/layout/Cargo.toml
  • @fitzgen: components/devtools_traits/Cargo.toml, components/devtools_traits/Cargo.toml, components/profile/Cargo.toml, components/profile_traits/Cargo.toml, components/profile_traits/Cargo.toml and 7 more
  • @KiChjang: components/script_traits/lib.rs, components/script_traits/lib.rs, components/net_traits/lib.rs, components/net_traits/lib.rs, components/script/dom/bindings/trace.rs and 7 more
  • @asajeffrey: components/constellation/Cargo.toml, components/webdriver_server/Cargo.toml, components/constellation/constellation.rs
@highfive
Copy link

highfive commented Jun 14, 2017

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!
  • These commits modify net, style, layout, gfx, and script code, but no tests are modified. Please consider adding a test!
@jdm
Copy link
Member

jdm commented Jun 14, 2017

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2017

⌛ Trying commit d3be9dd with merge 6c2fd94...
bors-servo added a commit that referenced this pull request Jun 14, 2017
@bors-servo
Auto merge of #17325 - Eijebong:serde1.0, r=<try>
Loading status checks…
6c2fd94 
Bump serde to 1.0

Update serde to 1.0

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16556

- [x] These changes do not require tests because it's a dependency bump

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17325)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2017

💔 Test failed - mac-rel-css1
@Eijebong Eijebong force-pushed the Eijebong:serde1.0 branch from d3be9dd to 74cdb44 Jun 14, 2017
@jdm
Copy link
Member

jdm commented Jun 14, 2017

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2017

⌛ Trying commit 74cdb44 with merge e2bb9fb...
bors-servo added a commit that referenced this pull request Jun 14, 2017
@bors-servo
Auto merge of #17325 - Eijebong:serde1.0, r=<try>
Loading status checks…
e2bb9fb 
Bump serde to 1.0

Update serde to 1.0

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16556

- [x] These changes do not require tests because it's a dependency bump

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17325)
<!-- Reviewable:end -->
@Eijebong
Copy link
Member Author

Eijebong commented Jun 14, 2017

Should be fixed (I hope !)
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2017

💔 Test failed - mac-dev-unit
@Eijebong
Bump serde to 1.0
Loading status checks…
92dc021
@Eijebong Eijebong force-pushed the Eijebong:serde1.0 branch from 74cdb44 to 92dc021 Jun 14, 2017
@Eijebong
Copy link
Member Author

Eijebong commented Jun 14, 2017

Turns out if you don't declare lifetimes, they don't exist... Who would have guessed that ?
@jdm
Copy link
Member

jdm commented Jun 14, 2017

@bors-servo: try
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2017

⌛ Trying commit 92dc021 with merge 4376ae6...
bors-servo added a commit that referenced this pull request Jun 14, 2017
@bors-servo
Auto merge of #17325 - Eijebong:serde1.0, r=<try>
Loading status checks…
4376ae6 
Bump serde to 1.0

Update serde to 1.0

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16556

- [x] These changes do not require tests because it's a dependency bump

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17325)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 14, 2017

☀️ Test successful - android, arm32, arm64, linux-dev, linux-rel-css, linux-rel-wpt, mac-dev-unit, mac-rel-css1, mac-rel-css2, mac-rel-wpt1, mac-rel-wpt2, mac-rel-wpt3, mac-rel-wpt4, windows-msvc-dev
State: approved= try=True
@jdm
Copy link
Member

jdm commented Jun 14, 2017

Could you provide links to all of the relevant PRs in other repositories?
@Eijebong
Copy link
Member Author

Eijebong commented Jun 14, 2017

Everything is in there #16556 (comment)
@SimonSapin
Copy link
Member

SimonSapin commented Jun 16, 2017

I’ve added servo/string-cache#190 which was missing, and published https://crates.io/crates/string_cache/0.6.0.

@Eijebong, servo/webrender#1359 (comment) is now waiting on you, and once that lands you should be able to remove the [replace] entries.

Thanks for all your work!
@SimonSapin SimonSapin mentioned this pull request Jun 16, 2017
Merged
@SimonSapin
Copy link
Member

SimonSapin commented Jun 16, 2017

@Eijebong I took over in #17355, I hope you don’t mind :)
bors-servo added a commit that referenced this pull request Jun 16, 2017
@bors-servo
Auto merge of #17355 - servo:serdeup, r=nox
Loading status checks…
66c130d 
Bump serde to 1.0

This is a rebase of #17325 with `[replace]` entries removed, a bunch more dependencies updated, and some more compile fixes. Original work by @Eijebong, thanks a lot!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17355)
<!-- Reviewable:end -->
@Eijebong
Copy link
Member Author

Eijebong commented Jun 16, 2017

This can be closed. Thanks @SimonSapin
@Eijebong Eijebong closed this Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nox nox

Labels
S-awaiting-review
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Update serde to 1.0.0
6 participants
@Eijebong @highfive @jdm @bors-servo @SimonSapin @nox
You can’t perform that action at this time.