Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upscroll_offset_query returns inner scrolls #17346
Closed
Conversation
Before this change scroll_offset_query returned the next scroll offset in the parents of the node. If there was no scroll offset it returned the window scroll offset. Now if no scrolls are present a zero scroll is returned ignoring window scrolling. This solves a bug for element.scrollLeft/Top returning wrong values. closes #17342
highfive
commented
Jun 15, 2017
highfive
commented
Jun 15, 2017
|
|
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jun 15, 2017
scroll_offset_query returns inner scrolls Before this change scroll_offset_query returned the next scroll offset in the parents of the node. If there was no scroll offset it returned the window scroll offset. Now if no scrolls are present a zero scroll is returned ignoring window scrolling. This solves a bug for element.scrollLeft/Top returning wrong values. closes #17342 r? @emilio <!-- Please describe your changes on the following line: --> --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: --> - [ ] `./mach build -d` does not report any errors - [ ] `./mach test-tidy` does not report any errors - [ ] These changes fix #__ (github issue number if applicable). <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because _____ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17346) <!-- Reviewable:end -->
|
|
|
|
Closing this since it surfaces other problems. Currently modifying one scrollTop changes the scrollTop of all elements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pyfisch commentedJun 15, 2017
•
edited by emilio
Before this change scroll_offset_query returned the
next scroll offset in the parents of the node.
If there was no scroll offset it returned the window
scroll offset.
Now if no scrolls are present a zero scroll is returned
ignoring window scrolling.
This solves a bug for element.scrollLeft/Top returning wrong
values.
closes #17342
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsThis change is