Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WR (CPU text optimizations, image format renames). #17352

Merged
merged 1 commit into from Jun 16, 2017

Conversation

@glennw
Copy link
Member

glennw commented Jun 16, 2017

This change is Reviewable

@highfive
Copy link

highfive commented Jun 16, 2017

Heads up! This PR modifies the following files:

  • @KiChjang: components/script/dom/canvasrenderingcontext2d.rs, components/net/image_cache.rs, components/net_traits/image/base.rs, components/net_traits/image/base.rs, components/script/dom/webglrenderingcontext.rs and 1 more
  • @fitzgen: components/script/dom/canvasrenderingcontext2d.rs, components/script/dom/webglrenderingcontext.rs, components/script/dom/paintworkletglobalscope.rs
  • @emilio: components/layout/display_list_builder.rs, components/canvas/webgl_paint_thread.rs, components/script/dom/webglrenderingcontext.rs
@highfive
Copy link

highfive commented Jun 16, 2017

warning Warning warning

  • These commits modify net, layout, and script code, but no tests are modified. Please consider adding a test!
@glennw
Copy link
Member Author

glennw commented Jun 16, 2017

r? anyone

@glennw
Copy link
Member Author

glennw commented Jun 16, 2017

@Eijebong FYI, this PR brings WR up to date in Servo. In case it doesn't land before your serde 1.0 changes are ready to go, you can use this as a base for the required WR API changes.

@emilio
Copy link
Member

emilio commented Jun 16, 2017

Looks good, though I'd expect some WebGL tests to fail... Let's see.

@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2017

📌 Commit e7b1e04 has been approved by emilio

@glennw
Copy link
Member Author

glennw commented Jun 16, 2017

@emilio Tests should be OK - it's just a rename of the format to match the actual layout. There's no actual byte ordering changes.

@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2017

Testing commit e7b1e04 with merge e1bce24...

bors-servo added a commit that referenced this pull request Jun 16, 2017
Update WR (CPU text optimizations, image format renames).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17352)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Jun 16, 2017

@bors-servo bors-servo merged commit e7b1e04 into servo:master Jun 16, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Jun 16, 2017
3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.